[debugger] remove remaining uses of the debug command processor.

test/mjsunit/debug-setbreakpoint.js

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 19 matching lines @@
 Debug = debug.Debug
 
 // Simple function which stores the last debug event.
 var listenerComplete = false;
 var exception = false;
 var f_script_id = 0;
 var g_script_id = 0;
 var h_script_id = 0;
 var f_line = 0;
 var g_line = 0;
-
-var base_request = '"seq":0,"type":"request","command":"setbreakpoint"'
-
-function safeEval(code) {
-  try {
-    return eval('(' + code + ')');
-  } catch (e) {
-    assertEquals(void 0, e);
-    return undefined;
-  }
-}
-
-function testArguments(dcp, arguments, success, is_script) {
-  var request = '{' + base_request + ',"arguments":' + arguments + '}'
-  var json_response = dcp.processDebugJSONRequest(request);
-  var response = safeEval(json_response);
-  if (success) {
-    assertTrue(response.success, request + ' -> ' + json_response);
-    if (is_script) {
-      assertEquals('scriptName', response.body.type, request + ' -> ' + json_response);
-    } else {
-      assertEquals('scriptId', response.body.type, request + ' -> ' + json_response);
-    }
-  } else {
-    assertFalse(response.success, request + ' -> ' + json_response);
-  }
-  return response;
-}
+var h_line = 0;
 
 function listener(event, exec_state, event_data, data) {
   try {
-  if (event == Debug.DebugEvent.Break) {
-    // Get the debug command processor.
-    var dcp = exec_state.debugCommandProcessor("unspecified_running_state");
+    if (event == Debug.DebugEvent.Break) {
+      Debug.setBreakPoint(exec_state.evaluateGlobal("f").value());
+      Debug.setBreakPoint(exec_state.evaluateGlobal("h").value());
+      Debug.setBreakPoint(exec_state.evaluateGlobal("f").value(), 1);
+      Debug.setBreakPoint(exec_state.evaluateGlobal("f").value(), 1);
+      Debug.setBreakPoint(exec_state.evaluateGlobal("f").value(),
+                          undefined, undefined, "i == 1");
 
-    // Test some illegal setbreakpoint requests.
-    var request = '{' + base_request + '}'
-    var response = safeEval(dcp.processDebugJSONRequest(request));
-    assertFalse(response.success);
+      Debug.setScriptBreakPointByName("test");
+      Debug.setScriptBreakPointByName("test", 1);
+      Debug.setScriptBreakPointByName("test", 1, 1);
 
-    var mirror;
+      Debug.setScriptBreakPointByName(f_script_id, f_line);
+      Debug.setScriptBreakPointByName(g_script_id, g_line);
+      Debug.setScriptBreakPointByName(h_script_id, h_line);
 
-    testArguments(dcp, '{}', false);
-    testArguments(dcp, '{"type":"xx"}', false);
-    testArguments(dcp, '{"type":"function"}', false);
-    testArguments(dcp, '{"type":"script"}', false);
-    testArguments(dcp, '{"target":"f"}', false);
-    testArguments(dcp, '{"type":"xx","target":"xx"}', false);
-    testArguments(dcp, '{"type":"function","target":1}', false);
-    testArguments(dcp, '{"type":"function","target":"f","line":-1}', false);
-    testArguments(dcp, '{"type":"function","target":"f","column":-1}', false);
-    testArguments(dcp, '{"type":"handle","target":"-1"}', false);
-    mirror = debug.MakeMirror(o);
-    testArguments(dcp, '{"type":"handle","target":' + mirror.handle() + '}', false);
-
-    // Test some legal setbreakpoint requests.
-    testArguments(dcp, '{"type":"function","target":"f"}', true, false);
-    testArguments(dcp, '{"type":"function","target":"h"}', true, false);
-    testArguments(dcp, '{"type":"function","target":"f","line":1}', true, false);
-    testArguments(dcp, '{"type":"function","target":"f","position":1}', true, false);
-    testArguments(dcp, '{"type":"function","target":"f","condition":"i == 1"}', true, false);
-    testArguments(dcp, '{"type":"function","target":"f","enabled":true}', true, false);
-    testArguments(dcp, '{"type":"function","target":"f","enabled":false}', true, false);
-
-    testArguments(dcp, '{"type":"script","target":"test"}', true, true);
-    testArguments(dcp, '{"type":"script","target":"test"}', true, true);
-    testArguments(dcp, '{"type":"script","target":"test","line":1}', true, true);
-    testArguments(dcp, '{"type":"script","target":"test","column":1}', true, true);
-
-    testArguments(dcp, '{"type":"scriptId","target":' + f_script_id + ',"line":' + f_line + '}', true, false);
-    testArguments(dcp, '{"type":"scriptId","target":' + g_script_id + ',"line":' + g_line + '}', true, false);
-    testArguments(dcp, '{"type":"scriptId","target":' + h_script_id + ',"line":' + h_line + '}', true, false);
-
-    mirror = debug.MakeMirror(f);
-    testArguments(dcp, '{"type":"handle","target":' + mirror.handle() + '}', true, false);
-    mirror = debug.MakeMirror(o.a);
-    testArguments(dcp, '{"type":"handle","target":' + mirror.handle() + '}', true, false);
-
-    testArguments(dcp, '{"type":"script","target":"sourceUrlScript","line":0}', true, true);
-
-    // Set a break point on a line with the comment, and check that actual position
-    // is the next line after the comment.
-    request = '{"type":"scriptId","target":' + g_script_id + ',"line":' + (g_line + 1) + '}';
-    response = testArguments(dcp, request, true, false);
-    assertEquals(g_line + 2, response.body.actual_locations[0].line);
-
-    // Indicate that all was processed.
-    listenerComplete = true;
-  }
+      // Indicate that all was processed.
+      listenerComplete = true;
+    }
   } catch (e) {
     exception = e
   };
 };
 
 // Add the debug event listener.
 Debug.setListener(listener);
 
 function f() {
   a=1
@@ skipping 39 matching lines @@
 
 // Try setting breakpoint by url specified in sourceURL
 
 var breakListenerCalled = false;
 
 function breakListener(event) {
   if (event == Debug.DebugEvent.Break)
     breakListenerCalled = true;
 }
 
+Debug.setBreakPoint(sourceUrlFunc);
+
 Debug.setListener(breakListener);
 
 sourceUrlFunc();
 
 assertTrue(breakListenerCalled, "Break listener not called on breakpoint set by sourceURL");
 
 
 // Breakpoint in a script with no statements test case. If breakpoint is set
 // to the script body, its actual position is taken from the nearest statement
 // below or like in this case is reset to the very end of the script.
 // Unless some precautions made, this position becomes out-of-range and
 // we get an exception.
 
 // Gets a script of 'i1' function and sets the breakpoint at line #4 which
 // should be empty.
 function SetBreakpointInI1Script() {
   var i_script = Debug.findScript(i1);
   assertTrue(!!i_script, "invalid script for i1");
   Debug.setScriptBreakPoint(Debug.ScriptBreakPointType.ScriptId,
                             i_script.id, 4);
 }
 
 // Creates the eval script and tries to set the breakpoint.
 // The tricky part is that the script function must be strongly reachable at the
 // moment. Since there's no way of simply getting the pointer to the function,
 // we run this code while the script function is being activated on stack.
 eval('SetBreakpointInI1Script()\nfunction i1(){}\n\n\n\nfunction i2(){}\n');