Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2557043005: [debugger] remove remaining uses of the debug command processor. (Closed)

Created:
4 years ago by Yang
Modified:
4 years ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] remove remaining uses of the debug command processor. R=jgruber@chromium.org BUG=v8:5510 Committed: https://crrev.com/44c7611931c05a95a14849e13f06f4bdd26df1d3 Cr-Commit-Position: refs/heads/master@{#41610}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1505 lines) Patch
M test/mjsunit/debug-changebreakpoint.js View 1 chunk +8 lines, -46 lines 0 comments Download
M test/mjsunit/debug-clearbreakpoint.js View 1 1 chunk +6 lines, -44 lines 0 comments Download
D test/mjsunit/debug-clearbreakpointgroup.js View 1 chunk +0 lines, -127 lines 0 comments Download
D test/mjsunit/debug-continue.js View 1 chunk +0 lines, -115 lines 0 comments Download
D test/mjsunit/debug-handle.js View 1 chunk +0 lines, -252 lines 0 comments Download
D test/mjsunit/debug-listbreakpoints.js View 1 chunk +0 lines, -210 lines 0 comments Download
D test/mjsunit/debug-mirror-cache.js View 1 chunk +0 lines, -85 lines 0 comments Download
D test/mjsunit/debug-references.js View 1 chunk +0 lines, -120 lines 0 comments Download
M test/mjsunit/debug-return-value.js View 1 2 chunks +0 lines, -42 lines 0 comments Download
D test/mjsunit/debug-scripts-request.js View 1 chunk +0 lines, -112 lines 0 comments Download
M test/mjsunit/debug-setbreakpoint.js View 1 2 chunks +22 lines, -86 lines 0 comments Download
D test/mjsunit/debug-setexceptionbreak.js View 1 chunk +0 lines, -119 lines 0 comments Download
D test/mjsunit/debug-suspend.js View 1 chunk +0 lines, -96 lines 0 comments Download
M test/mjsunit/modules-debug-scopes2.js View 2 chunks +0 lines, -51 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Yang
4 years ago (2016-12-08 13:57:16 UTC) #1
Yang
Deleted tests either only test things that are relevant to the debug command processor or ...
4 years ago (2016-12-08 13:58:20 UTC) #2
jgruber
lgtm. Home stretch for moving all --expose-debug-as to test/debugger/ then?
4 years ago (2016-12-08 15:21:07 UTC) #3
Yang
On 2016/12/08 15:21:07, jgruber wrote: > lgtm. Home stretch for moving all --expose-debug-as to test/debugger/ ...
4 years ago (2016-12-08 15:49:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557043005/1
4 years ago (2016-12-08 15:49:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/13797) v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years ago (2016-12-08 16:05:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557043005/20001
4 years ago (2016-12-09 07:57:09 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 08:26:11 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-09 08:26:44 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/44c7611931c05a95a14849e13f06f4bdd26df1d3
Cr-Commit-Position: refs/heads/master@{#41610}

Powered by Google App Engine
This is Rietveld 408576698