Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2557043003: Make media controls not depend on the webkitfullscreenchange event (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index 3e66e714d787c2019aa964c29ced7d6b6d426afb..9b236f089ba3ed9b3177438b80563e9344365b98 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -3389,6 +3389,7 @@ void HTMLMediaElement::exitFullscreen() {
}
void HTMLMediaElement::didEnterFullscreen() {
+ configureMediaControls();
if (mediaControls())
mediaControls()->enteredFullscreen();
// FIXME: There is no embedder-side handling in layout test mode.
@@ -3402,6 +3403,7 @@ void HTMLMediaElement::didEnterFullscreen() {
}
void HTMLMediaElement::didExitFullscreen() {
+ configureMediaControls();
if (mediaControls())
mediaControls()->exitedFullscreen();
if (webMediaPlayer())
@@ -3642,14 +3644,6 @@ void HTMLMediaElement::configureTextTrackDisplay() {
updateTextTrackDisplay();
}
-EventDispatchHandlingState* HTMLMediaElement::preDispatchEventHandler(
- Event* event) {
- if (event && event->type() == EventTypeNames::webkitfullscreenchange)
- configureMediaControls();
-
- return nullptr;
-}
-
// TODO(srirama.m): Merge it to resetMediaElement if possible and remove it.
void HTMLMediaElement::resetMediaPlayerAndMediaSource() {
closeMediaSource();
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698