third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp - Issue 2557033002: Remove ContextLifecycleObserver from NotificationManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

Issue 2557033002: Remove ContextLifecycleObserver from NotificationManager (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/notifications/NotificationManager.cpp ('K') | « third_party/WebKit/Source/modules/notifications/NotificationManager.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp b/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

index 482eaf42f0de5311ce13094337df1087d0d9dea5..7b6b9930efb7a7881b9238db3615f2c291e77a98 100644

--- a/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

+++ b/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

@@ -79,7 +79,8 @@ ScriptPromise ServiceWorkerRegistrationNotifications::showNotification(

// If permission for notification's origin is not "granted", reject the

// promise with a TypeError exception, and terminate these substeps.

- if (NotificationManager::from(executionContext)->permissionStatus() !=

+ if (NotificationManager::from(executionContext)

+ ->permissionStatus(executionContext) !=

mojom::blink::PermissionStatus::GRANTED)

return ScriptPromise::reject(

scriptState,