Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2557023002: Remove FetchManager::m_isStopped (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FetchManager::m_isStopped It's redundant. GlobalFetch is using FetchManager::m_isStopped to check if the context has already been destroyed. However, the check is not needed because scriptState->contextIsValid() is already checking the fact. BUG=610176 Committed: https://crrev.com/1d61819fbeda1b74a725e77185766aba0a0cf82f Cr-Commit-Position: refs/heads/master@{#437173}

Patch Set 1 #

Patch Set 2 : temp #

Patch Set 3 : temp #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M third_party/WebKit/Source/modules/fetch/FetchManager.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp View 1 2 1 chunk +0 lines, -4 lines 1 comment Download

Messages

Total messages: 12 (6 generated)
haraken
PTAL
4 years ago (2016-12-07 06:02:16 UTC) #2
haraken
https://codereview.chromium.org/2557023002/diff/40001/third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp File third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp (left): https://codereview.chromium.org/2557023002/diff/40001/third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp#oldcode48 third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp:48: if (m_fetchManager->isStopped()) { If this returns true, scriptState->contextIsValid() should ...
4 years ago (2016-12-07 06:05:29 UTC) #4
yhirano
lgtm
4 years ago (2016-12-08 02:11:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557023002/40001
4 years ago (2016-12-08 02:22:57 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-08 04:07:11 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-08 04:09:45 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1d61819fbeda1b74a725e77185766aba0a0cf82f
Cr-Commit-Position: refs/heads/master@{#437173}

Powered by Google App Engine
This is Rietveld 408576698