third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.cpp - Issue 2556993005: [blink] Split TaskType::Internal into InternalTimer and InternalLoading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.cpp

Issue 2556993005: [blink] Split TaskType::Internal into InternalTimer and InternalLoading. (Closed)

Patch Set: One more fix Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp ('k') | third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.cpp

diff --git a/third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.cpp b/third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.cpp

index f3269bee8768ac0da891da9111cdab30d13c1609..479747cc0c0bf66f0e4eab987fc04d5e3e1100db 100644

--- a/third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.cpp

+++ b/third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.cpp

@@ -18,7 +18,7 @@ namespace blink {

void ThreadedObjectProxyBase::countFeature(UseCounter::Feature feature) {

getParentFrameTaskRunners()

- ->get(TaskType::Internal)

+ ->get(TaskType::UnspecedTimer)

->postTask(BLINK_FROM_HERE,

crossThreadBind(&ThreadedMessagingProxyBase::countFeature,

messagingProxyWeakPtr(), feature));

@@ -26,7 +26,7 @@ void ThreadedObjectProxyBase::countFeature(UseCounter::Feature feature) {

void ThreadedObjectProxyBase::countDeprecation(UseCounter::Feature feature) {

getParentFrameTaskRunners()

- ->get(TaskType::Internal)

+ ->get(TaskType::UnspecedTimer)

->postTask(BLINK_FROM_HERE,

crossThreadBind(&ThreadedMessagingProxyBase::countDeprecation,

messagingProxyWeakPtr(), feature));

@@ -37,7 +37,7 @@ void ThreadedObjectProxyBase::reportConsoleMessage(MessageSource source,

const String& message,

SourceLocation* location) {

getParentFrameTaskRunners()

- ->get(TaskType::Internal)

+ ->get(TaskType::UnspecedTimer)

->postTask(

BLINK_FROM_HERE,

crossThreadBind(&ThreadedMessagingProxyBase::reportConsoleMessage,

@@ -63,7 +63,7 @@ ParentFrameTaskRunners* ThreadedObjectProxyBase::getParentFrameTaskRunners() {

void ThreadedObjectProxyBase::didCloseWorkerGlobalScope() {

getParentFrameTaskRunners()

- ->get(TaskType::Internal)

+ ->get(TaskType::UnspecedTimer)

->postTask(

BLINK_FROM_HERE,

crossThreadBind(&ThreadedMessagingProxyBase::terminateGlobalScope,

@@ -73,7 +73,7 @@ void ThreadedObjectProxyBase::didCloseWorkerGlobalScope() {

void ThreadedObjectProxyBase::didTerminateWorkerThread() {

// This will terminate the MessagingProxy.

getParentFrameTaskRunners()

- ->get(TaskType::Internal)

+ ->get(TaskType::UnspecedTimer)

->postTask(

BLINK_FROM_HERE,

crossThreadBind(&ThreadedMessagingProxyBase::workerThreadTerminated,