third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp - Issue 2556993005: [blink] Split TaskType::Internal into InternalTimer and InternalLoading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp

Issue 2556993005: [blink] Split TaskType::Internal into InternalTimer and InternalLoading. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/FrameView.cpp ('K') | « third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp ('k') | third_party/WebKit/Source/core/workers/WorkerThread.cpp » ('j') | third_party/WebKit/Source/core/workers/WorkerThread.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp

diff --git a/third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp b/third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp

index 3db954f0b94e6aede9c917a0acacbca81ec6e109..d573e101f873f02bf21df700f01fe6eaac113282 100644

--- a/third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp

+++ b/third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp

@@ -44,7 +44,7 @@ void ThreadedWorkletObjectProxy::reportConsoleMessage(

const String& message,

SourceLocation* location) {

getParentFrameTaskRunners()

- ->get(TaskType::Internal)

+ ->get(TaskType::InternalTimer)

->postTask(

BLINK_FROM_HERE,

crossThreadBind(&ThreadedWorkletMessagingProxy::reportConsoleMessage,

@@ -72,7 +72,7 @@ ThreadedWorkletObjectProxy::getParentFrameTaskRunners() {

void ThreadedWorkletObjectProxy::didCloseWorkerGlobalScope() {

getParentFrameTaskRunners()

- ->get(TaskType::Internal)

+ ->get(TaskType::InternalTimer)

->postTask(

BLINK_FROM_HERE,

crossThreadBind(&ThreadedWorkletMessagingProxy::terminateGlobalScope,

@@ -82,7 +82,7 @@ void ThreadedWorkletObjectProxy::didCloseWorkerGlobalScope() {

void ThreadedWorkletObjectProxy::didTerminateWorkerThread() {

// This will terminate the MessagingProxy.

getParentFrameTaskRunners()

- ->get(TaskType::Internal)

+ ->get(TaskType::InternalTimer)

->postTask(BLINK_FROM_HERE,

crossThreadBind(

&ThreadedWorkletMessagingProxy::workerThreadTerminated,