[blink] Split TaskType::Internal into InternalTimer and InternalLoading.

third_party/WebKit/Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
@@ skipping 402 matching lines @@
       m_importsController(this, initializer.importsController()),
       m_contextFeatures(ContextFeatures::defaultSwitch()),
       m_wellFormed(false),
       m_implementation(this, nullptr),
       m_printing(NotPrinting),
       m_paginatedForScreen(false),
       m_compatibilityMode(NoQuirksMode),
       m_compatibilityModeLocked(false),
       m_hasAutofocused(false),
       m_clearFocusedElementTimer(
-          TaskRunnerHelper::get(TaskType::Internal, this),
+          TaskRunnerHelper::get(TaskType::InternalTimer, this),
           this,
           &Document::clearFocusedElementTimerFired),
       m_domTreeVersion(++s_globalTreeVersion),
       m_styleVersion(0),
       m_listenerTypes(0),
       m_mutationObserverTypes(0),
       m_styleEngine(this, nullptr),
       m_styleSheetList(this, nullptr),
       m_visitedLinkState(VisitedLinkState::create(*this)),
       m_visuallyOrdered(false),
       m_readyState(Complete),
       m_parsingState(FinishedParsing),
       m_gotoAnchorNeededAfterStylesheetsLoad(false),
       m_containsValidityStyleRules(false),
       m_containsPlugins(false),
       m_updateFocusAppearanceSelectionBahavior(SelectionBehaviorOnFocus::Reset),
       m_ignoreDestructiveWriteCount(0),
       m_throwOnDynamicMarkupInsertionCount(0),
       m_markers(new DocumentMarkerController(*this)),
       m_updateFocusAppearanceTimer(
-          TaskRunnerHelper::get(TaskType::Internal, this),
+          TaskRunnerHelper::get(TaskType::InternalTimer, this),
           this,
           &Document::updateFocusAppearanceTimerFired),
       m_cssTarget(nullptr),
       m_loadEventProgress(LoadEventNotRun),
       m_startTime(currentTime()),
       m_scriptRunner(ScriptRunner::create(this)),
       m_xmlVersion("1.0"),
       m_xmlStandalone(StandaloneUnspecified),
       m_hasXMLDeclaration(0),
       m_designMode(false),
       m_isRunningExecCommand(false),
       m_hasReceivedUserGesture(false),
       m_hasAnnotatedRegions(false),
       m_annotatedRegionsDirty(false),
       m_documentClasses(documentClasses),
       m_isViewSource(false),
       m_sawElementsInKnownNamespaces(false),
       m_isSrcdocDocument(false),
       m_isMobileDocument(false),
       m_layoutView(0),
       m_contextDocument(initializer.contextDocument()),
       m_hasFullscreenSupplement(false),
       m_loadEventDelayCount(0),
       m_loadEventDelayTimer(TaskRunnerHelper::get(TaskType::Networking, this),
                             this,
                             &Document::loadEventDelayTimerFired),
-      m_pluginLoadingTimer(TaskRunnerHelper::get(TaskType::Internal, this),
-                           this,
-                           &Document::pluginLoadingTimerFired),
+      m_pluginLoadingTimer(
+          TaskRunnerHelper::get(TaskType::InternalLoading, this),
+          this,
+          &Document::pluginLoadingTimerFired),
       m_documentTiming(*this),
       m_writeRecursionIsTooDeep(false),
       m_writeRecursionDepth(0),
       m_registrationContext(initializer.registrationContext(this)),
       m_elementDataCacheClearTimer(
-          TaskRunnerHelper::get(TaskType::Internal, this),
+          TaskRunnerHelper::get(TaskType::InternalTimer, this),
           this,
           &Document::elementDataCacheClearTimerFired),
       m_timeline(DocumentTimeline::create(this)),
       m_compositorPendingAnimations(new CompositorPendingAnimations()),
       m_templateDocumentHost(nullptr),
       m_didAssociateFormControlsTimer(
-          TaskRunnerHelper::get(TaskType::Internal, this),
+          TaskRunnerHelper::get(TaskType::InternalLoading, this),
           this,
           &Document::didAssociateFormControlsTimerFired),
       m_timers(TaskRunnerHelper::get(TaskType::Timer, this)->clone()),
       m_hasViewportUnits(false),
       m_parserSyncPolicy(AllowAsynchronousParsing),
       m_nodeCount(0),
       m_wouldLoadReason(Created),
       m_passwordCount(0) {
   if (m_frame) {
     DCHECK(m_frame->page());
@@ skipping 3849 matching lines @@
                               OriginAccessEntry::AllowRegisterableDomains));
   }
   return *m_accessEntryFromURL;
 }
 
 void Document::sendSensitiveInputVisibility() {
   if (m_sensitiveInputVisibilityTask.isActive())
     return;
 
   m_sensitiveInputVisibilityTask =
-      TaskRunnerHelper::get(TaskType::Internal, this)
+      TaskRunnerHelper::get(TaskType::InternalLoading, this)

[Sami, 2016/12/08 17:05:08]

InternalTimer IMO

[altimin, 2016/12/08 17:47:40]

I'm inclined to make unthrottled (because sensitive input visibility sounds
scary and we might want to run it without throttling due to privacy/security
reasons).

           ->postCancellableTask(
               BLINK_FROM_HERE,
               WTF::bind(&Document::sendSensitiveInputVisibilityInternal,
                         wrapWeakPersistent(this)));
 }
 
 void Document::sendSensitiveInputVisibilityInternal() {
   if (!frame())
     return;
 
@@ skipping 2222 matching lines @@
 }
 
 void showLiveDocumentInstances() {
   WeakDocumentSet& set = liveDocumentSet();
   fprintf(stderr, "There are %u documents currently alive:\n", set.size());
   for (Document* document : set)
     fprintf(stderr, "- Document %p URL: %s\n", document,
             document->url().getString().utf8().data());
 }
 #endif