Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Side by Side Diff: components/nacl/renderer/nexe_load_manager.h

Issue 2556983003: NaCl plugin: Make ServiceRuntime::Shutdown() kill the NaCl loader (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_NACL_RENDERER_NEXE_LOAD_MANAGER_H_ 5 #ifndef COMPONENTS_NACL_RENDERER_NEXE_LOAD_MANAGER_H_
6 #define COMPONENTS_NACL_RENDERER_NEXE_LOAD_MANAGER_H_ 6 #define COMPONENTS_NACL_RENDERER_NEXE_LOAD_MANAGER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 // TODO(dmichael): Everything below this comment should eventually be made 61 // TODO(dmichael): Everything below this comment should eventually be made
62 // private, when ppb_nacl_private_impl.cc is no longer using them directly. 62 // private, when ppb_nacl_private_impl.cc is no longer using them directly.
63 // The intent is for this class to only expose functions for reporting a 63 // The intent is for this class to only expose functions for reporting a
64 // load state transition (e.g., ReportLoadError, ReportProgress, 64 // load state transition (e.g., ReportLoadError, ReportProgress,
65 // ReportLoadAbort, etc.) 65 // ReportLoadAbort, etc.)
66 void set_trusted_plugin_channel( 66 void set_trusted_plugin_channel(
67 std::unique_ptr<TrustedPluginChannel> channel); 67 std::unique_ptr<TrustedPluginChannel> channel);
68 void set_manifest_service_channel( 68 void set_manifest_service_channel(
69 std::unique_ptr<ManifestServiceChannel> channel); 69 std::unique_ptr<ManifestServiceChannel> channel);
70 70
71 void close_trusted_plugin_channel();
bbudge 2016/12/08 23:20:00 nit: not a getter or setter, so use camel case and
Derek Schuff 2016/12/09 00:11:34 Done.
72
71 PP_NaClReadyState nacl_ready_state(); 73 PP_NaClReadyState nacl_ready_state();
72 void set_nacl_ready_state(PP_NaClReadyState ready_state); 74 void set_nacl_ready_state(PP_NaClReadyState ready_state);
73 75
74 void SetReadOnlyProperty(PP_Var key, PP_Var value); 76 void SetReadOnlyProperty(PP_Var key, PP_Var value);
75 void SetLastError(const std::string& error); 77 void SetLastError(const std::string& error);
76 void LogToConsole(const std::string& message); 78 void LogToConsole(const std::string& message);
77 79
78 bool is_installed() const { return is_installed_; } 80 bool is_installed() const { return is_installed_; }
79 81
80 int32_t exit_status() const { return exit_status_; } 82 int32_t exit_status() const { return exit_status_; }
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 base::SharedMemoryHandle crash_info_shmem_handle_; 190 base::SharedMemoryHandle crash_info_shmem_handle_;
189 191
190 std::unique_ptr<TrustedPluginChannel> trusted_plugin_channel_; 192 std::unique_ptr<TrustedPluginChannel> trusted_plugin_channel_;
191 std::unique_ptr<ManifestServiceChannel> manifest_service_channel_; 193 std::unique_ptr<ManifestServiceChannel> manifest_service_channel_;
192 base::WeakPtrFactory<NexeLoadManager> weak_factory_; 194 base::WeakPtrFactory<NexeLoadManager> weak_factory_;
193 }; 195 };
194 196
195 } // namespace nacl 197 } // namespace nacl
196 198
197 #endif // COMPONENTS_NACL_RENDERER_NEXE_LOAD_MANAGER_H_ 199 #endif // COMPONENTS_NACL_RENDERER_NEXE_LOAD_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | components/nacl/renderer/nexe_load_manager.cc » ('j') | components/nacl/renderer/ppb_nacl_private.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698