Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: content/renderer/media/android/stream_texture_wrapper_impl.h

Issue 2556983002: Fix SetStreamTextureSize crash (Closed)
Patch Set: Addressed comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/android/stream_texture_wrapper_impl.h
diff --git a/content/renderer/media/android/stream_texture_wrapper_impl.h b/content/renderer/media/android/stream_texture_wrapper_impl.h
index b18b18d79531e117885b554becac91edcf984b4c..048cc9c6e20e037d9fcd1c835f2e8d14ea5ad2e7 100644
--- a/content/renderer/media/android/stream_texture_wrapper_impl.h
+++ b/content/renderer/media/android/stream_texture_wrapper_impl.h
@@ -55,14 +55,15 @@ class CONTENT_EXPORT StreamTextureWrapperImpl
// Additional threading considerations:
// - Can be called from any thread.
// - Initialization will be posted to |main_task_runner_|.
- // - |init_cb| will be run on the calling thread.
+ // - |init_cb| will be run on the calling thread, and will be passed a bool
+ // indicating whether the initialization was successful.
// - New frames will be signaled on |compositor_task_runner| via |client|'s
// DidReceiveFrame() method.
void Initialize(
const base::Closure& received_frame_cb,
const gfx::Size& natural_size,
scoped_refptr<base::SingleThreadTaskRunner> compositor_task_runner,
- const base::Closure& init_cb) override;
+ const StreamTextureWrapperInitCB& init_cb) override;
// Should be called when the Video size changes.
// Can be called from any thread, but runs on |main_task_runner_|.
@@ -92,7 +93,7 @@ class CONTENT_EXPORT StreamTextureWrapperImpl
void Destroy() override;
void InitializeOnMainThread(const base::Closure& received_frame_cb,
- const base::Closure& init_cb);
+ const StreamTextureWrapperInitCB& init_cb);
void ReallocateVideoFrame(const gfx::Size& natural_size);

Powered by Google App Engine
This is Rietveld 408576698