Wire the VR omnibox directly to visible security state changes.

Wire the VR omnibox directly to visible security state changes.

Rather than querying for security state changes on navigation events,
let WebContentsObserver trigger observers on a state change.

BUG=641508
Committed: https://crrev.com/7d2397c4a60454a20ddc189d5966c72c63b551e8
Cr-Commit-Position: refs/heads/master@{#437348}

[cjgrant, 2016-12-08 17:14:48]

cjgrant@chromium.org changed reviewers:
+ bshe@chromium.org, mthiesse@chromium.org

[cjgrant, 2016-12-08 17:14:49]

Folks, also see this change if curious about the WebContentsObserver rework.

https://codereview.chromium.org/2562503002/

[mthiesse, 2016-12-08 17:50:23]

lgtm

[bshe, 2016-12-08 18:21:15]

On 2016/12/08 17:50:23, mthiesse wrote:
> lgtm

lgtm

[cjgrant, 2016-12-08 18:22:12]

The CQ bit was checked by cjgrant@chromium.org

[commit-bot: I haz the power, 2016-12-08 18:22:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 19:07:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 19:07:52]

Failed to apply patch for
chrome/browser/android/vr_shell/vr_web_contents_observer.h:
While running git apply --index -p1;
  error: patch failed:
chrome/browser/android/vr_shell/vr_web_contents_observer.h:39
  error: chrome/browser/android/vr_shell/vr_web_contents_observer.h: patch does
not apply

Patch:       chrome/browser/android/vr_shell/vr_web_contents_observer.h
Index: chrome/browser/android/vr_shell/vr_web_contents_observer.h
diff --git a/chrome/browser/android/vr_shell/vr_web_contents_observer.h
b/chrome/browser/android/vr_shell/vr_web_contents_observer.h
index
9b1a594390dbfe0e11a241bc8148ec92e5e29b2b..03291f41a8067d4668d7a2eb1311fed54540153d
100644
--- a/chrome/browser/android/vr_shell/vr_web_contents_observer.h
+++ b/chrome/browser/android/vr_shell/vr_web_contents_observer.h
@@ -39,6 +39,9 @@ class CONTENT_EXPORT VrWebContentsObserver
       content::NavigationHandle* navigation_handle) override;
   void DidToggleFullscreenModeForTab(
       bool entered_fullscreen, bool will_cause_resize) override;
+  void SecurityStyleChanged(
+      blink::WebSecurityStyle security_style,
+      const content::SecurityStyleExplanations& explanations) override;
   void WebContentsDestroyed() override;
   void WasHidden() override;

[cjgrant, 2016-12-08 20:44:46]

The CQ bit was checked by cjgrant@chromium.org

[cjgrant, 2016-12-08 20:44:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
mthiesse@chromium.org, bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2556963006/#ps20001
(title: "Rebase onto 2524423002")

[commit-bot: I haz the power, 2016-12-08 20:45:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 21:30:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481229886222860,
"parent_rev": "77b1106d0795de9583158efde2424751abe5f4f9", "commit_rev":
"d58b21a3200390b351639f3c70f65d9852ae754d"}

[commit-bot: I haz the power, 2016-12-08 21:30:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-08 21:32:16]

Description was changed from

==========
Wire the VR omnibox directly to visible security state changes.

Rather than querying for security state changes on navigation events,
let WebContentsObserver trigger observers on a state change.

BUG=641508
==========

to

==========
Wire the VR omnibox directly to visible security state changes.

Rather than querying for security state changes on navigation events,
let WebContentsObserver trigger observers on a state change.

BUG=641508

Committed: https://crrev.com/7d2397c4a60454a20ddc189d5966c72c63b551e8
Cr-Commit-Position: refs/heads/master@{#437348}
==========

[commit-bot: I haz the power, 2016-12-08 21:32:17]

Patchset 2 (id:??) landed as
https://crrev.com/7d2397c4a60454a20ddc189d5966c72c63b551e8
Cr-Commit-Position: refs/heads/master@{#437348}