Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2556963005: [wasm][asm.js] Use x&(x-1) trick to speed up life. (Closed)

Created:
4 years ago by bradnelson
Modified:
4 years ago
Reviewers:
Benedikt Meurer, bradn
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Use x&(x-1) trick to speed up life. Using x&(x-1) to check for power of two masks usable at runtime speeds up the life benchmark. Borrowing this from SimplifiedLowering for the AsmJsRemS internal wasm opcode. Leaving this out for general wasm as we should be doing this optimization in LLVM. BUG=v8:4203 TEST=None R=bmeurer@chromium.org Committed: https://crrev.com/4cfe91cf58e831bd8efb211184bd9c6e182e88f2 Cr-Commit-Position: refs/heads/master@{#41581}

Patch Set 1 #

Patch Set 2 : gix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -20 lines) Patch
M src/compiler/wasm-compiler.cc View 1 1 chunk +85 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
bradn
4 years ago (2016-12-08 08:24:31 UTC) #4
Benedikt Meurer
LGTM from my side.
4 years ago (2016-12-08 09:34:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556963005/20001
4 years ago (2016-12-08 09:34:52 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 09:36:27 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-08 09:36:43 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4cfe91cf58e831bd8efb211184bd9c6e182e88f2
Cr-Commit-Position: refs/heads/master@{#41581}

Powered by Google App Engine
This is Rietveld 408576698