Enable CertVerifyProcWeakDigestTest tests on android

Enable CertVerifyProcWeakDigestTest tests on android.

They should be passing since https://crrev.com/b92e6f5c2a
In fact, MAYBE_VerifyRoot/CertVerifyProcWeakDigestTest.VerifyDetectsAlgorithm has already been running on android since https://crrev.com/e04a95b881 as it was not using WRAPPED_INSTANTIATE_TEST_CASE_P.

BUG=none

Committed: https://crrev.com/164fb098d4af1f865f57c59f2e4deff3dd62bd9a
Cr-Commit-Position: refs/heads/master@{#436829}

[mattm, 2016-12-07 00:17:21]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 00:18:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2016-12-07 00:56:32]

Description was changed from

==========
enable CertVerifyProcWeakDigestTest tests on android

BUG=
==========

to

==========
Enable CertVerifyProcWeakDigestTest tests on android.

They should be passing since https://crrev.com/b92e6f5c2a
In fact, MAYBE_VerifyRoot/CertVerifyProcWeakDigestTest.VerifyDetectsAlgorithm
has already been running on android since https://crrev.com/e04a95b881 as it was
not using WRAPPED_INSTANTIATE_TEST_CASE_P.

BUG=none
==========

[mattm, 2016-12-07 00:57:33]

mattm@chromium.org changed reviewers:
+ davidben@chromium.org

[commit-bot: I haz the power, 2016-12-07 01:06:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 01:06:27]

Dry run: This issue passed the CQ dry run.

[davidben, 2016-12-07 01:13:58]

lgtm

https://codereview.chromium.org/2556963002/diff/1/net/cert/cert_verify_proc_u...
File net/cert/cert_verify_proc_unittest.cc (right):

https://codereview.chromium.org/2556963002/diff/1/net/cert/cert_verify_proc_u...
net/cert/cert_verify_proc_unittest.cc:1779: #if defined(USE_NSS_CERTS) ||
defined(OS_IOS)
Probably for separate, but now that iOS doesn't use NSS anymore, I suspect you
can take these OS_IOS's out too.

[mattm, 2016-12-07 01:37:59]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2016-12-07 01:38:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 01:42:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481074679209600, "parent_rev":
"254f1a0ee0fd37dfaf1db3e73c6aba00a31c535e", "commit_rev":
"3be756853503fdc8c3fd9afe64281232b7d386b9"}

[commit-bot: I haz the power, 2016-12-07 01:43:00]

Description was changed from

==========
Enable CertVerifyProcWeakDigestTest tests on android.

They should be passing since https://crrev.com/b92e6f5c2a
In fact, MAYBE_VerifyRoot/CertVerifyProcWeakDigestTest.VerifyDetectsAlgorithm
has already been running on android since https://crrev.com/e04a95b881 as it was
not using WRAPPED_INSTANTIATE_TEST_CASE_P.

BUG=none
==========

to

==========
Enable CertVerifyProcWeakDigestTest tests on android.

They should be passing since https://crrev.com/b92e6f5c2a
In fact, MAYBE_VerifyRoot/CertVerifyProcWeakDigestTest.VerifyDetectsAlgorithm
has already been running on android since https://crrev.com/e04a95b881 as it was
not using WRAPPED_INSTANTIATE_TEST_CASE_P.

BUG=none
==========

[commit-bot: I haz the power, 2016-12-07 01:43:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-07 01:45:10]

Description was changed from

==========
Enable CertVerifyProcWeakDigestTest tests on android.

They should be passing since https://crrev.com/b92e6f5c2a
In fact, MAYBE_VerifyRoot/CertVerifyProcWeakDigestTest.VerifyDetectsAlgorithm
has already been running on android since https://crrev.com/e04a95b881 as it was
not using WRAPPED_INSTANTIATE_TEST_CASE_P.

BUG=none
==========

to

==========
Enable CertVerifyProcWeakDigestTest tests on android.

They should be passing since https://crrev.com/b92e6f5c2a
In fact, MAYBE_VerifyRoot/CertVerifyProcWeakDigestTest.VerifyDetectsAlgorithm
has already been running on android since https://crrev.com/e04a95b881 as it was
not using WRAPPED_INSTANTIATE_TEST_CASE_P.

BUG=none

Committed: https://crrev.com/164fb098d4af1f865f57c59f2e4deff3dd62bd9a
Cr-Commit-Position: refs/heads/master@{#436829}
==========

[commit-bot: I haz the power, 2016-12-07 01:45:11]

Patchset 1 (id:??) landed as
https://crrev.com/164fb098d4af1f865f57c59f2e4deff3dd62bd9a
Cr-Commit-Position: refs/heads/master@{#436829}

[mattm, 2016-12-07 02:50:50]

https://codereview.chromium.org/2556963002/diff/1/net/cert/cert_verify_proc_u...
File net/cert/cert_verify_proc_unittest.cc (right):

https://codereview.chromium.org/2556963002/diff/1/net/cert/cert_verify_proc_u...
net/cert/cert_verify_proc_unittest.cc:1779: #if defined(USE_NSS_CERTS) ||
defined(OS_IOS)
On 2016/12/07 01:13:58, davidben wrote:
> Probably for separate, but now that iOS doesn't use NSS anymore, I suspect you
> can take these OS_IOS's out too.

Thanks, I gave that a shot (https://codereview.chromium.org/2560703002/).
Perhaps unsurprisingly, it fails on the same subset of them that Sierra does.
(That's on ios-simulator.) I'll revisit once I've thought about how to address
those tests on Sierra.

(It passed on ios-device, but looking at the bot logs it doesn't seem to
actually run any tests?)