Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2556943002: WebGL2 & 16-bit depth capture: Upload video to GL_RED float texture. (Closed)

Created:
4 years ago by aleksandar.stojiljkovic
Modified:
4 years ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, darin-cc_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebGL2 & 16-bit depth capture: Upload video to GL_RED float texture. This enables lossless access to 16-bit video stream using GL_RED float texture on WebGL2. The patch extends the WebGL1 approach using RGBA32F textures for 16-bit depth video [*] by using single component GL_RED float [**] texture on WebGL2. * https://crrev.com/2476693002/ ** Float is used for no-precision-loss access to 16-bit data normalized to [0-1.0] range using formula value_float = value_16bit/65535.0. BUG=369849, 624436 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/014802a3945cbf187a74bda8b2fdc21404d44104 Cr-Commit-Position: refs/heads/master@{#437371}

Patch Set 1 #

Patch Set 2 : rebase issue fix. #

Patch Set 3 : --enable-es3-apis is required for WebGL2 on Android. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -29 lines) Patch
M content/test/data/media/depth_stream_test_utilities.js View 1 chunk +30 lines, -0 lines 0 comments Download
M content/test/data/media/getusermedia-depth-capture.html View 1 5 chunks +39 lines, -10 lines 0 comments Download
M content/test/gpu/gpu_tests/depth_capture_integration_test.py View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.cc View 4 chunks +26 lines, -13 lines 0 comments Download
M media/renderers/skcanvas_video_renderer_unittest.cc View 5 chunks +79 lines, -1 line 0 comments Download

Messages

Total messages: 29 (13 generated)
aleksandar.stojiljkovic
kbr@chromium.org: PTAL at content/test hubbe@chromium.org: PTAL at media Thanks.
4 years ago (2016-12-06 23:29:22 UTC) #2
Ken Russell (switch to Gerrit)
Note: I filed http://crbug.com/672388 about the android_optional_gpu_tests_rel tryjob failure.
4 years ago (2016-12-08 08:28:50 UTC) #5
Ken Russell (switch to Gerrit)
Nice. LGTM
4 years ago (2016-12-08 08:33:48 UTC) #6
aleksandar.stojiljkovic
+xhwang@, PTAL at media. in case hubbe is busy. kbr@, thanks. On 2016/12/08 08:28:50, Ken ...
4 years ago (2016-12-08 16:08:28 UTC) #8
hubbe
media/* LGTM
4 years ago (2016-12-08 18:18:35 UTC) #9
xhwang
hubbe@ is here and is still the best person to review this :)
4 years ago (2016-12-08 18:18:38 UTC) #11
aleksandar.stojiljkovic
hubbe@, xhwang@, thanks. On 2016/12/08 18:18:38, xhwang wrote: > hubbe@ is here and is still ...
4 years ago (2016-12-08 18:30:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556943002/60001
4 years ago (2016-12-08 18:31:12 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82584)
4 years ago (2016-12-08 20:12:14 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556943002/60001
4 years ago (2016-12-08 20:15:03 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82655)
4 years ago (2016-12-08 22:16:53 UTC) #20
aleksandar.stojiljkovic
On 2016/12/08 22:16:53, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years ago (2016-12-08 22:22:46 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556943002/60001
4 years ago (2016-12-08 22:23:30 UTC) #23
aleksandar.stojiljkovic
On 2016/12/08 22:23:30, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years ago (2016-12-08 22:26:49 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years ago (2016-12-08 22:39:11 UTC) #27
commit-bot: I haz the power
4 years ago (2016-12-08 22:41:04 UTC) #29
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/014802a3945cbf187a74bda8b2fdc21404d44104
Cr-Commit-Position: refs/heads/master@{#437371}

Powered by Google App Engine
This is Rietveld 408576698