Chromium Code Reviews| Index: include/core/SkReader32.h |
| diff --git a/include/core/SkReader32.h b/include/core/SkReader32.h |
| index 7e8038d0ae3a7913cf3c5ee036b866b7720e0963..7e919b5baba50eb4569ca18dc9eb67b74ac0f8e9 100644 |
| --- a/include/core/SkReader32.h |
| +++ b/include/core/SkReader32.h |
| @@ -40,7 +40,7 @@ public: |
| const void* peek() const { return fCurr; } |
| size_t available() const { return fStop - fCurr; } |
| - bool isAvailable(size_t size) const { return fCurr + size <= fStop; } |
|
sugoi1
2014/04/28 20:15:20
"fCurr + size" can overflow easily since "size" ca
|
| + bool isAvailable(size_t size) const { return size <= available(); } |
|
reed1
2014/04/28 20:18:02
nit: this->available()
sugoi1
2014/04/28 20:25:06
Done.
|
| void rewind() { fCurr = fBase; } |