Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Issue 2556903002: Allow an external URL with FROM_API qualifier to be forwarded to ARC (Closed)

Created:
4 years ago by Yusuke Sato
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Allow an external URL with FROM_API qualifier to be forwarded to ARC for better AppAuth compatibility. In a highly unusual situation, allowing FROM_API could trigger infinite Chrome tab creation. This CL also adds code for detecting and stopping the loop, just in case. End users will almost never see the safety checks to kick in, though. BUG=670465 TEST=unit_tests passed, also manually confirmed that when |always_ask_user| is true, "Always" preference set by the user is ignored. Review-Url: https://codereview.chromium.org/2540013004 Cr-Commit-Position: refs/heads/master@{#436017} (cherry picked from commit 0c7e06f5b85f0304bd62f61a9b2ae391e97f3183) Committed: https://chromium.googlesource.com/chromium/src/+/f5d5e34508dfe64379c170ad1e3236b20c685b97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -64 lines) Patch
M chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc View 17 chunks +94 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog_unittest.cc View 21 chunks +75 lines, -26 lines 0 comments Download
M components/arc/intent_helper/page_transition_util.h View 1 chunk +4 lines, -3 lines 0 comments Download
M components/arc/intent_helper/page_transition_util.cc View 2 chunks +3 lines, -13 lines 0 comments Download
M components/arc/intent_helper/page_transition_util_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Yusuke Sato
4 years ago (2016-12-06 21:33:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f5d5e34508dfe64379c170ad1e3236b20c685b97.

Powered by Google App Engine
This is Rietveld 408576698