third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp - Issue 2556893003: Remove ContextLifecycleObserver from NavigatorServiceWorker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

Issue 2556893003: Remove ContextLifecycleObserver from NavigatorServiceWorker (Closed)

Patch Set: temp Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('K') | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

index 42f19da0d51a1b0b4d8cbc8416492ba5958ad7e8..3ada7d2fd3c43e4f95849aaaaf5a053b582cfd99 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

@@ -177,7 +177,7 @@ class ServiceWorkerContainerTest : public ::testing::Test {

provide(WTF::makeUnique<NotReachedWebServiceWorkerProvider>());

ServiceWorkerContainer* container =

- ServiceWorkerContainer::create(getExecutionContext());

+ ServiceWorkerContainer::create(getExecutionContext(), nullptr);

ScriptState::Scope scriptScope(getScriptState());

RegistrationOptions options;

options.setScope(scope);

@@ -191,7 +191,7 @@ class ServiceWorkerContainerTest : public ::testing::Test {

provide(WTF::makeUnique<NotReachedWebServiceWorkerProvider>());

ServiceWorkerContainer* container =

- ServiceWorkerContainer::create(getExecutionContext());

+ ServiceWorkerContainer::create(getExecutionContext(), nullptr);

ScriptState::Scope scriptScope(getScriptState());

ScriptPromise promise =

container->getRegistration(getScriptState(), documentURL);

@@ -332,7 +332,7 @@ TEST_F(ServiceWorkerContainerTest,

provide(stubProvider.provider());

ServiceWorkerContainer* container =

- ServiceWorkerContainer::create(getExecutionContext());

+ ServiceWorkerContainer::create(getExecutionContext(), nullptr);

// register

{

@@ -358,7 +358,7 @@ TEST_F(ServiceWorkerContainerTest,

provide(stubProvider.provider());

ServiceWorkerContainer* container =

- ServiceWorkerContainer::create(getExecutionContext());

+ ServiceWorkerContainer::create(getExecutionContext(), nullptr);

{

ScriptState::Scope scriptScope(getScriptState());