Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.h

Issue 2556893003: Remove ContextLifecycleObserver from NavigatorServiceWorker (Closed)
Patch Set: temp Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.h
diff --git a/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.h b/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.h
index c9abaf27672d5166d03663fbfd71e233c95fba38..4bb8eb57abe5c8602286b69f1003b8b720950a03 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.h
+++ b/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.h
@@ -5,7 +5,6 @@
#ifndef NavigatorServiceWorker_h
#define NavigatorServiceWorker_h
-#include "core/dom/ContextLifecycleObserver.h"
#include "core/frame/Navigator.h"
#include "modules/ModulesExport.h"
#include "platform/Supplementable.h"
@@ -20,8 +19,7 @@ class ServiceWorkerContainer;
class MODULES_EXPORT NavigatorServiceWorker final
: public GarbageCollected<NavigatorServiceWorker>,
- public Supplement<Navigator>,
- public ContextLifecycleObserver {
+ public Supplement<Navigator> {
USING_GARBAGE_COLLECTED_MIXIN(NavigatorServiceWorker);
public:
@@ -34,6 +32,7 @@ class MODULES_EXPORT NavigatorServiceWorker final
static ServiceWorkerContainer* serviceWorker(ExecutionContext*,
Navigator&,
String& errorMessage);
+ void clearServiceWorker();
DECLARE_VIRTUAL_TRACE();
@@ -44,9 +43,6 @@ class MODULES_EXPORT NavigatorServiceWorker final
static const char* supplementName();
- // ContextLifecycleObserver override.
- void contextDestroyed() override;
-
Member<ServiceWorkerContainer> m_serviceWorker;
};

Powered by Google App Engine
This is Rietveld 408576698