Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp

Issue 2556893003: Remove ContextLifecycleObserver from NavigatorServiceWorker (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp b/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp
index cd8b179cb1c56c988ee0a3a816570919f6b8557c..8fa4de03015ed8ef40e1c8936fdf4030d297fcaf 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp
@@ -12,9 +12,7 @@
namespace blink {
-NavigatorServiceWorker::NavigatorServiceWorker(Navigator& navigator)
- : ContextLifecycleObserver(navigator.frame() ? navigator.frame()->document()
- : nullptr) {}
+NavigatorServiceWorker::NavigatorServiceWorker(Navigator& navigator) {}
NavigatorServiceWorker* NavigatorServiceWorker::from(Document& document) {
if (!document.frame() || !document.frame()->domWindow())
@@ -112,14 +110,9 @@ ServiceWorkerContainer* NavigatorServiceWorker::serviceWorker(
return m_serviceWorker.get();
}
-void NavigatorServiceWorker::contextDestroyed() {
- m_serviceWorker = nullptr;
-}
-
DEFINE_TRACE(NavigatorServiceWorker) {
visitor->trace(m_serviceWorker);
Supplement<Navigator>::trace(visitor);
- ContextLifecycleObserver::trace(visitor);
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698