xfa/fwl/core/cfwl_comboboxproxy.cpp - Issue 2556873004: Convert GetWidgetRect to return rect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/core/cfwl_comboboxproxy.cpp

Issue 2556873004: Convert GetWidgetRect to return rect. (Closed)

Patch Set: Review feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/core/cfwl_comboboxproxy.cpp

diff --git a/xfa/fwl/core/cfwl_comboboxproxy.cpp b/xfa/fwl/core/cfwl_comboboxproxy.cpp

index be45f2b72954549fc3221a6368dd8e042e33ca09..b7c56378cf2760b18ac217b075bea48a23819ba1 100644

--- a/xfa/fwl/core/cfwl_comboboxproxy.cpp

+++ b/xfa/fwl/core/cfwl_comboboxproxy.cpp

@@ -70,8 +70,7 @@ void CFWL_ComboBoxProxy::OnLButtonDown(CFWL_Message* pMessage) {

CFWL_NoteDriver* pDriver =

static_cast<CFWL_NoteDriver*>(pApp->GetNoteDriver());

- CFX_RectF rtWidget;

- GetWidgetRect(rtWidget, false);

+ CFX_RectF rtWidget = GetWidgetRect();

rtWidget.left = rtWidget.top = 0;

CFWL_MsgMouse* pMsg = static_cast<CFWL_MsgMouse*>(pMessage);

@@ -100,8 +99,7 @@ void CFWL_ComboBoxProxy::OnLButtonUp(CFWL_Message* pMessage) {

}

CFWL_MsgMouse* pMsg = static_cast<CFWL_MsgMouse*>(pMessage);

- CFX_RectF rect;

- GetWidgetRect(rect, false);

+ CFX_RectF rect = GetWidgetRect();

rect.left = rect.top = 0;

if (!rect.Contains(pMsg->m_fx, pMsg->m_fy) &&

m_pComboBox->IsDropListVisible()) {

« no previous file with comments | « xfa/fwl/core/cfwl_combobox.cpp ('k') | xfa/fwl/core/cfwl_combolist.cpp » ('j') | no next file with comments »