Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: media/video/video_decode_accelerator.h

Issue 2556873003: VDA: document the behavior of calling Reset before NotifyFlushDone. (Closed)
Patch Set: document flush is cancelled and NotifyFlushDone may not come Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/video/video_decode_accelerator.h
diff --git a/media/video/video_decode_accelerator.h b/media/video/video_decode_accelerator.h
index c14050c6cf3554f06d9666b9db427625b26ef2d2..f298f850d694e68c9170de21f890896182125740 100644
--- a/media/video/video_decode_accelerator.h
+++ b/media/video/video_decode_accelerator.h
@@ -286,7 +286,10 @@ class MEDIA_EXPORT VideoDecodeAccelerator {
// Resets the decoder: all pending inputs are dropped immediately and the
// decoder returned to a state ready for further Decode()s, followed by
// NotifyResetDone() being called on the client. Can be used to implement
- // "seek".
+ // "seek". After Flush is called, it is OK to call Reset before receiving
+ // NotifyFlushDone() and VDA should cancel the flush. Note NotifyFlushDone()
+ // may be on the way to the client. If client gets NotifyFlushDone(), it
+ // should be before NotifyResetDone().
virtual void Reset() = 0;
// An optional graphics surface that the VDA should render to. For setting
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698