Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2556873002: Revert of Enable traffic shaping in loading.mobile benchmark (Closed)

Created:
4 years ago by dtu
Modified:
4 years ago
CC:
chromium-reviews, telemetry-reviews_chromium.org, kouhei (in TOK)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable traffic shaping in loading.mobile benchmark (patchset #1 id:40001 of https://codereview.chromium.org/2493063002/ ) Reason for revert: loading.mobile started failing after this CL. See http://crbug.com/671640#c10 Original issue's description: > Enable traffic shaping in loading.mobile benchmark > > After this patch, loading.mobile benchmark will run with two traffic > configurations: > > - No traffic shaping (as before) > - "Regular 3G" (Down 750kbps, Up 250kbps, 100ms RTT) > > BUG=664420 > > Committed: https://crrev.com/9febcf5133be621b82954c0fea52123fa4f8b7a8 > Cr-Commit-Position: refs/heads/master@{#435230} TBR=nednguyen@google.com,ksakamoto@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=664420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -19 lines) Patch
M tools/perf/benchmarks/loading.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/perf/page_sets/loading_mobile.py View 8 chunks +11 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dtu
Created Revert of Enable traffic shaping in loading.mobile benchmark
4 years ago (2016-12-06 20:25:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556873002/1
4 years ago (2016-12-06 20:26:00 UTC) #3
rnephew (Reviews Here)
4 years ago (2016-12-06 20:43:23 UTC) #5
On 2016/12/06 20:26:00, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Unchecked commit, test was timing out due to taking too long with traffic
shaping. Increasing the time to see if that fixes it first.

https://codereview.chromium.org/2556753003/

Powered by Google App Engine
This is Rietveld 408576698