Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2556833003: [profiler] Add extra CHECK to track down crbug.com/665398 (Closed)

Created:
4 years ago by alph
Modified:
4 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[profiler] Add extra CHECK to track down crbug.com/665398 BUG=chromium:665398 Committed: https://crrev.com/dfc0bb63a1bc115d39f29cfc338aed5676578c4b Cr-Commit-Position: refs/heads/master@{#41545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M src/profiler/profile-generator.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/profiler/profile-generator-inl.h View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
alph
ptal
4 years ago (2016-12-07 06:59:12 UTC) #2
Yang
On 2016/12/07 06:59:12, alph wrote: > ptal lgtm
4 years ago (2016-12-07 09:19:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556833003/1
4 years ago (2016-12-07 09:58:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 10:23:56 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dfc0bb63a1bc115d39f29cfc338aed5676578c4b Cr-Commit-Position: refs/heads/master@{#41545}
4 years ago (2016-12-07 10:24:49 UTC) #9
alph
4 years ago (2016-12-20 02:01:24 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2588973003/ by alph@chromium.org.

The reason for reverting is: Not needed anymore. The bug is fixed..

Powered by Google App Engine
This is Rietveld 408576698