[SPInvalidation] Invalidate paint property when transform etc. change

third_party/WebKit/Source/core/layout/LayoutObject.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc.
  *               All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
  *               (http://www.torchmobile.com/)
@@ skipping 1445 matching lines @@
 
 StyleDifference LayoutObject::adjustStyleDifference(
     StyleDifference diff) const {
   if (diff.transformChanged() && isSVG()) {
     // Skip a full layout for transforms at the html/svg boundary which do not
     // affect sizes inside SVG.
     if (!isSVGRoot())
       diff.setNeedsFullLayout();
   }
 
-  if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
+  if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled()) {
     // Text nodes share style with their parents but the checked styles don't
     // apply to them, hence the !isText() check.
     if (!isText() && (diff.transformChanged() || diff.opacityChanged() ||
                       diff.zIndexChanged() || diff.filterChanged() ||
                       diff.backdropFilterChanged())) {
       // We don't need to invalidate paint of objects on SPv2 when only paint
       // property or paint order change. Mark the painting layer needing repaint
       // for changed paint property or paint order. Raster invalidation will be
       // issued if needed during paint.
-      ObjectPaintInvalidator(*this).slowSetPaintingLayerNeedsRepaint();
+      if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())

[pdr., 2016/12/06 22:03:55]

Should this be:
"if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled())"?

[pdr., 2016/12/06 22:05:50]

Nevermind.

LGTM

[Xianzhu, 2016/12/06 22:12:00]

This is needed by spv2. For SlimmingPaintInvalidation we'll still execute the
old paint invalidation path so doesn't need this.

[Xianzhu, 2016/12/06 22:12:50]

Also never mind my reply :)

+        ObjectPaintInvalidator(*this).slowSetPaintingLayerNeedsRepaint();
 
       // When transform, opacity, etc. change, paint properties will also change
       // so we need to mark this object as needing an update.
       getMutableForPainting().setNeedsPaintPropertyUpdate();
     }
-  } else {
+  }
+
+  if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
     // If transform changed, and the layer does not paint into its own separate
     // backing, then we need to invalidate paints.
     if (diff.transformChanged()) {
       // Text nodes share style with their parents but transforms don't apply to
       // them, hence the !isText() check.
       if (!isText() && (!hasLayer() ||
                         !toLayoutBoxModelObject(this)
                              ->layer()
                              ->hasStyleDeterminedDirectCompositingReasons()))
         diff.setNeedsPaintInvalidationSubtree();
@@ skipping 2008 matching lines @@
     const blink::LayoutObject* root = object1;
     while (root->parent())
       root = root->parent();
     root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
   } else {
     WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)");
   }
 }
 
 #endif