Include full du dump in feedback reports

Include full du dump in feedback reports

R=steel@chromium.org
BUG=672188
TEST=Start the feedback app on chrome os, the system information should contain an
entry "system_files" containing info about all recursive directories in the system.

Committed: https://crrev.com/07380defeda24d05120554d63fa211b9a13d2628
Cr-Commit-Position: refs/heads/master@{#437118}

[afakhry, 2016-12-07 21:17:12]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 21:17:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 22:04:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 22:04:47]

Dry run: This issue passed the CQ dry run.

[afakhry, 2016-12-07 23:31:36]

Rahul, PTAL. Thanks.

[afakhry, 2016-12-08 00:11:51]

Excluded the Downloads folder as agreed. PTAL.

[Rahul Chaturvedi, 2016-12-08 00:17:02]

https://codereview.chromium.org/2556783006/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/system_logs/command_line_log_source.cc (right):

https://codereview.chromium.org/2556783006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/system_logs/command_line_log_source.cc:79: " grep -v -e
\\/home\\/chronos\\/.*\\/Downloads\\/");
This might need to be everything under /home/.*/Downloads. Is a second user
profile under the logged in user also under /home/chronos/xxxx/Downloads?
Or is it under /home/user-xxxx/user/Downloads?

If you've already verified this then, lgtm - otherwise lgtm after you change
this to the correct regular expression :)

[afakhry, 2016-12-08 00:30:51]

https://codereview.chromium.org/2556783006/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/system_logs/command_line_log_source.cc (right):

https://codereview.chromium.org/2556783006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/system_logs/command_line_log_source.cc:79: " grep -v -e
\\/home\\/chronos\\/.*\\/Downloads\\/");
On 2016/12/08 00:17:02, Rahul Chaturvedi wrote:
> This might need to be everything under /home/.*/Downloads. Is a second user
> profile under the logged in user also under /home/chronos/xxxx/Downloads?
> Or is it under /home/user-xxxx/user/Downloads?
> 
> If you've already verified this then, lgtm - otherwise lgtm after you change
> this to the correct regular expression :)

You're right. /home/user/<hash>/Downloads still need to be excluded.

Done.

[Rahul Chaturvedi, 2016-12-08 00:31:38]

lgtm

[afakhry, 2016-12-08 00:32:05]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2016-12-08 00:33:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 01:37:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481157125437680,
"parent_rev": "b834bfcabf62f80624fc00af4ca599ea8a9c266f", "commit_rev":
"304eec151b1cc3383117f4976471441874e67ea8"}

[commit-bot: I haz the power, 2016-12-08 01:37:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-08 01:40:07]

Description was changed from

==========
Include full du dump in feedback reports

R=steel@chromium.org
BUG=672188
TEST=Start the feedback app on chrome os, the system information should contain
an
entry "system_files" containing info about all recursive directories in the
system.
==========

to

==========
Include full du dump in feedback reports

R=steel@chromium.org
BUG=672188
TEST=Start the feedback app on chrome os, the system information should contain
an
entry "system_files" containing info about all recursive directories in the
system.

Committed: https://crrev.com/07380defeda24d05120554d63fa211b9a13d2628
Cr-Commit-Position: refs/heads/master@{#437118}
==========

[commit-bot: I haz the power, 2016-12-08 01:40:08]

Patchset 3 (id:??) landed as
https://crrev.com/07380defeda24d05120554d63fa211b9a13d2628
Cr-Commit-Position: refs/heads/master@{#437118}