Issue 255673005: Add ro_MD.txt to collocal.mk and rebuild icudtl.dat

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 255673005: Add ro_MD.txt to collocal.mk and rebuild icudtl.dat (Closed)

Created:
6 years, 8 months ago by jungshik at Google

Modified:
6 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/

Visibility:
Public.

Description

Add ro_MD.txt to collocal.mk and rebuild icudtl.dat Somehow icupkg (used in generating icudtl.dll on Windows) complains that coll/ro_MD required for coll/ro is missing in icudtl.dat. Because ro_MD is ust an empty alias and it's not a size issue, I'm adding it to silence icupkg. (will check with the upstream about this unexpected dependencies). Note that I'm not updating the assembly source files and icudtl.dat for Android because it should not matter to them. BUG=132145 TEST=On Windows, makedata in allinone.snl does not complain. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265987

Patch Set 1 #

Created: 6 years, 8 months ago

		Unified diffs	Side-by-side diffs	Stats (+1 line, -1 line)
	M	icu52/source/data/coll/collocal.mk	View	1 chunk	+1 line, -1 line	0 comments
	M	icu52/source/data/in/icudtl.dat	View		Binary file		0 comments

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

6 years, 8 months ago (2014-04-24 21:02:54 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r265987 (presubmit successful).

Expand Messages | Collapse Messages