Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2556723007:
Add WebKit Linux Trusty (dbg) to config/builders.py. (Closed)
DescriptionAdd WebKit Linux Trusty (dbg) to config/builders.py.
Context: See http://crrev.com/2557593006.
Committed: https://crrev.com/938e1073667b007c6cdda221b464ce854c895a64
Cr-Commit-Position: refs/heads/master@{#437425}
Patch Set 1 #
Messages
Total messages: 16 (6 generated)
qyearsley@chromium.org changed reviewers: + wangxianzhu@chromium.org
The CQ bit was checked by wangxianzhu@chromium.org
lgtm About the flaky test, I've created a patch: virtual/android/media/mediadocument/media-document-with-download-button.html which will be landed soon.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/12/08 at 23:19:22, wangxianzhu wrote: > lgtm > > About the flaky test, I've created a patch: virtual/android/media/mediadocument/media-document-with-download-button.html which will be landed soon. Alright, sounds good, then the one I uploaded can be closed?
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thought of the following which might be an issue or not: When the line was removed because of missing linux debug bot, the test was also flaky on the existing release bot (like Image Image Pass) though the final results were success. The script seemed to treat this kind of flakiness as a Pass. Is this true? If yes should we keep the flaky line?
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481246565881130, "parent_rev":
"31e7d23e6393f82220713a204f1df692b57abd4e", "commit_rev":
"446e618afd0a05f9b4d09ce76a6b6bca6313b1f2"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add WebKit Linux Trusty (dbg) to config/builders.py. Context: See http://crrev.com/2557593006. ========== to ========== Add WebKit Linux Trusty (dbg) to config/builders.py. Context: See http://crrev.com/2557593006. Committed: https://crrev.com/938e1073667b007c6cdda221b464ce854c895a64 Cr-Commit-Position: refs/heads/master@{#437425} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/938e1073667b007c6cdda221b464ce854c895a64 Cr-Commit-Position: refs/heads/master@{#437425}
Message was sent while issue was closed.
On 2016/12/09 at 01:35:41, wangxianzhu wrote: > Thought of the following which might be an issue or not: > > When the line was removed because of missing linux debug bot, the test was also flaky on the existing release bot (like Image Image Pass) though the final results were success. The script seemed to treat this kind of flakiness as a Pass. Is this true? If yes should we keep the flaky line? What probably happened was that because the line was marked [ Linux Debug ], the update-test-expectations script only looked at Linux Debug builders (and found none). I think in this case, even if the line is flaky on more platforms, then that line should be removed, since the line has no effect. If the line had just [ Linux ] then it should have looked at "WebKit Linux Trusty" results as well, and if it found failures then it would have kept the line. So, I think the current behavior of the script makes sense, even though to be fully accurate, the line probably originally should have had [ Linux ] rather than [ Linux Debug ]. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
