Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2556723005: Add a perf test for generating linked summaries. (Closed)

Created:
4 years ago by Paul Berry
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Refactor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -25 lines) Patch
M pkg/front_end/tool/perf.dart View 1 7 chunks +95 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Paul Berry
4 years ago (2016-12-07 22:10:16 UTC) #2
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2556723005/diff/1/pkg/front_end/tool/perf.dart File pkg/front_end/tool/perf.dart (right): https://codereview.chromium.org/2556723005/diff/1/pkg/front_end/tool/perf.dart#newcode300 pkg/front_end/tool/perf.dart:300: setupForLink(libraryUris, getUnit, getDeclaredVariable); is there a difference between prelink ...
4 years ago (2016-12-07 23:21:29 UTC) #3
Paul Berry
https://codereview.chromium.org/2556723005/diff/1/pkg/front_end/tool/perf.dart File pkg/front_end/tool/perf.dart (right): https://codereview.chromium.org/2556723005/diff/1/pkg/front_end/tool/perf.dart#newcode300 pkg/front_end/tool/perf.dart:300: setupForLink(libraryUris, getUnit, getDeclaredVariable); On 2016/12/07 23:21:29, Siggi Cherem (dart-lang) ...
4 years ago (2016-12-07 23:54:41 UTC) #4
Siggi Cherem (dart-lang)
lgtm
4 years ago (2016-12-08 00:24:38 UTC) #5
Paul Berry
4 years ago (2016-12-08 00:27:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
926dfb751e4e1f49c8594bbb26fa992264b780f3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698