Make ifdefs consistent in WebKit/Source/core/frame/.

Make ifdefs consistent in WebKit/Source/core/frame/.

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
Committed: https://crrev.com/0a6c04dde993b8357457b2e2bbbd19eefc53b2ad
Cr-Commit-Position: refs/heads/master@{#436728}

[Alexander Alekseev, 2016-12-06 09:59:20]

alemate@chromium.org changed reviewers:
+ bokan@chromium.org

[Alexander Alekseev, 2016-12-06 09:59:20]

assertSubtreeIsLaidOut() and others are hidden behind DCHECK_IS_ON() condition.
So this CL makes it all consistent.

Please review.

[Alexander Alekseev, 2016-12-06 09:59:27]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 09:59:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 12:23:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 12:23:25]

Dry run: This issue passed the CQ dry run.

[bokan, 2016-12-06 17:37:45]

lgtm

[Alexander Alekseev, 2016-12-06 21:02:24]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-12-06 21:03:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 21:17:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481058144567300, "parent_rev":
"72f1836d7ce8a0d0508af76a7413ad4e560148b2", "commit_rev":
"d39ce27ebcbc7a4ff3e6bf80c25aef6906c836f7"}

[commit-bot: I haz the power, 2016-12-06 21:18:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-06 21:21:52]

Description was changed from

==========
Make ifdefs consistent in WebKit/Source/core/frame/.

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
==========

to

==========
Make ifdefs consistent in WebKit/Source/core/frame/.

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660

Committed: https://crrev.com/0a6c04dde993b8357457b2e2bbbd19eefc53b2ad
Cr-Commit-Position: refs/heads/master@{#436728}
==========

[commit-bot: I haz the power, 2016-12-06 21:21:53]

Patchset 1 (id:??) landed as
https://crrev.com/0a6c04dde993b8357457b2e2bbbd19eefc53b2ad
Cr-Commit-Position: refs/heads/master@{#436728}