Embedding-CSP: Ports subsumption

Embedding-CSP: Ports subsumption

When we check for subsumption, we need to make sure that even if ports
are different but are defaults for the specified protocols, we return
correct result. Consider:

A = http://example.com:80
B = https://example.com:443

Then A subsumes B.
Moreover, A is similar to B and their intersection should be
`https://example.com:443`.

BUG=647588
Committed: https://crrev.com/9881be66406b729bfa518c4aaf54430ed5bc0683
Cr-Commit-Position: refs/heads/master@{#436916}

[amalika, 2016-12-06 09:29:12]

amalika@google.com changed reviewers:
+ jochen@chromium.org, mkwst@chromium.org

[amalika, 2016-12-06 09:29:13]

https://codereview.chromium.org/2556713002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/csp/CSPSource.cpp (right):

https://codereview.chromium.org/2556713002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/csp/CSPSource.cpp:159: m_scheme.length() >
other->m_scheme.length())
By this point, we know that A and B are similar, i.e. their schemes match. The
only case when one length could be greater than the other is if it is more
secure. So we want to pick that port.

[Mike West, 2016-12-06 13:41:09]

LGTM % nit. Thanks!

https://codereview.chromium.org/2556713002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/csp/CSPSource.cpp (right):

https://codereview.chromium.org/2556713002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/csp/CSPSource.cpp:159: m_scheme.length() >
other->m_scheme.length())
On 2016/12/06 at 09:29:13, amalika wrote:
> By this point, we know that A and B are similar, i.e. their schemes match. The
only case when one length could be greater than the other is if it is more
secure. So we want to pick that port.

Can you spell this out, please? Reading `http` and `https` (or `ws` and `wss`)
is more verbose, but will be much clearer in a year when I've forgotten all
about the rationale for the length check here. :)

[amalika, 2016-12-07 09:27:46]

The CQ bit was checked by amalika@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 09:28:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amalika, 2016-12-07 09:33:56]

The CQ bit was unchecked by amalika@google.com

[amalika, 2016-12-07 09:39:53]

The CQ bit was checked by amalika@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 09:40:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 11:15:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 11:15:25]

Dry run: This issue passed the CQ dry run.

[amalika, 2016-12-07 11:40:35]

The CQ bit was checked by amalika@google.com

[amalika, 2016-12-07 11:40:35]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2556713002/#ps20001
(title: "Adding a comment")

[commit-bot: I haz the power, 2016-12-07 11:40:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 11:44:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481110835392660,
"parent_rev": "43af5b2f81c5986bb5164e2a1975d9866764b972", "commit_rev":
"1fca32f8090d12996e6d9c8e91785c24004ee077"}

[commit-bot: I haz the power, 2016-12-07 11:45:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-07 11:47:18]

Description was changed from

==========
Embedding-CSP: Ports subsumption

When we check for subsumption, we need to make sure that even if ports
are different but are defaults for the specified protocols, we return
correct result. Consider:

A = http://example.com:80
B = https://example.com:443

Then A subsumes B.
Moreover, A is similar to B and their intersection should be
`https://example.com:443`.

BUG=647588
==========

to

==========
Embedding-CSP: Ports subsumption

When we check for subsumption, we need to make sure that even if ports
are different but are defaults for the specified protocols, we return
correct result. Consider:

A = http://example.com:80
B = https://example.com:443

Then A subsumes B.
Moreover, A is similar to B and their intersection should be
`https://example.com:443`.

BUG=647588

Committed: https://crrev.com/9881be66406b729bfa518c4aaf54430ed5bc0683
Cr-Commit-Position: refs/heads/master@{#436916}
==========

[commit-bot: I haz the power, 2016-12-07 11:47:19]

Patchset 2 (id:??) landed as
https://crrev.com/9881be66406b729bfa518c4aaf54430ed5bc0683
Cr-Commit-Position: refs/heads/master@{#436916}