Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 25567002: MIPS: Lazily save double registers for HCallRuntime instructions within Hydrogen code stubs. (Closed)

Created:
7 years, 2 months ago by kilvadyb
Modified:
7 years, 2 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Lazily save double registers for HCallRuntime instructions within Hydrogen code stubs. Port r17044 (94843cc) Original commit message: Right now we eagerly save all allocatable double registers upon entry to every Hydrogen code stub that uses HCallRuntime, and restore them when we return. Since the HCallRuntime is on the fallback path for code stubs, this is both a waste of time and stack space in almost every case. This patch adds a flag to the HCallRuntime, which controls whether the instruction saves the double register itself (using the save doubles flag for the CEntryStub), or whether its up the surrounding code to handle the clobbering of double registers. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -24 lines) Patch
M src/mips/lithium-codegen-mips.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/mips/lithium-mips.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +10 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +3 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
7 years, 2 months ago (2013-10-01 18:13:42 UTC) #1
Paul Lind
LGTM, I'll land it.
7 years, 2 months ago (2013-10-01 19:00:48 UTC) #2
Paul Lind
7 years, 2 months ago (2013-10-01 19:06:17 UTC) #3
Committed as r17057.

Powered by Google App Engine
This is Rietveld 408576698