[compiler] Improve let+const decision in AstNumbering.

[compiler] Improve let+const decision in AstNumbering.

Incooperate suggestion from adamk@ to only sent lexical variables to
I+TF that require explicit initialization, i.e. don't send named
function expressions to I+TF. This should recover most of the regression
now.

Also introduce a regression test for the original let issue.

BUG=chromium:670691, v8:5666
R=adamk@chromium.org,yangguo@chromium.org

Committed: https://crrev.com/78691367163ad318a6b441f03de5e7f5bf400df7
Cr-Commit-Position: refs/heads/master@{#41507}

[Benedikt Meurer, 2016-12-06 05:37:52]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 05:38:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2016-12-06 05:39:57]

On 2016/12/06 05:37:50, Benedikt Meurer wrote:

lgtm, but please add a comment.

[Benedikt Meurer, 2016-12-06 05:43:18]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-12-06 05:43:18]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2556663002/#ps20001
(title: "Add comment.")

[commit-bot: I haz the power, 2016-12-06 05:43:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2016-12-06 05:48:14]

https://codereview.chromium.org/2556663002/diff/20001/src/ast/ast-numbering.cc
File src/ast/ast-numbering.cc (right):

https://codereview.chromium.org/2556663002/diff/20001/src/ast/ast-numbering.c...
src/ast/ast-numbering.cc:166: // initialization, i.e. ES2015 stylt const and
let, but not
Is 'stylt' a typo?

[Benedikt Meurer, 2016-12-06 05:48:32]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2016-12-06 05:48:52]

On 2016/12/06 05:48:14, Yang wrote:
> https://codereview.chromium.org/2556663002/diff/20001/src/ast/ast-numbering.cc
> File src/ast/ast-numbering.cc (right):
> 
>
https://codereview.chromium.org/2556663002/diff/20001/src/ast/ast-numbering.c...
> src/ast/ast-numbering.cc:166: // initialization, i.e. ES2015 stylt const and
> let, but not
> Is 'stylt' a typo?

It is :-)

[Benedikt Meurer, 2016-12-06 05:48:55]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-12-06 05:48:56]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2556663002/#ps40001
(title: "Fix typo.")

[commit-bot: I haz the power, 2016-12-06 05:49:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 06:12:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481003335871260,
"parent_rev": "5e55df2bb4dfa05bae86750eda8197a34583862c", "commit_rev":
"bf200aff596c1e1550d1df3260643df870351d06"}

[commit-bot: I haz the power, 2016-12-06 06:12:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-06 06:13:28]

Description was changed from

==========
[compiler] Improve let+const decision in AstNumbering.

Incooperate suggestion from adamk@ to only sent lexical variables to
I+TF that require explicit initialization, i.e. don't send named
function expressions to I+TF. This should recover most of the regression
now.

Also introduce a regression test for the original let issue.

BUG=chromium:670691,v8:5666
R=adamk@chromium.org,yangguo@chromium.org
==========

to

==========
[compiler] Improve let+const decision in AstNumbering.

Incooperate suggestion from adamk@ to only sent lexical variables to
I+TF that require explicit initialization, i.e. don't send named
function expressions to I+TF. This should recover most of the regression
now.

Also introduce a regression test for the original let issue.

BUG=chromium:670691,v8:5666
R=adamk@chromium.org,yangguo@chromium.org

Committed: https://crrev.com/78691367163ad318a6b441f03de5e7f5bf400df7
Cr-Commit-Position: refs/heads/master@{#41507}
==========

[commit-bot: I haz the power, 2016-12-06 06:13:29]

Patchset 3 (id:??) landed as
https://crrev.com/78691367163ad318a6b441f03de5e7f5bf400df7
Cr-Commit-Position: refs/heads/master@{#41507}

[adamk, 2016-12-06 18:24:43]

lgtm