Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2556653003: Cancel drag operation when the tab RenderWidgetHostView does not exist (Mac) (Merge to M56) (Closed)

Created:
4 years ago by EhsanK
Modified:
4 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Cancel drag operation when the tab RenderWidgetHostView does not exist (Mac) When the tab's RenderWidgetHostView is nullptr, we cannot and should not select any RenderWidgetHosts for a drag destination. Therefore, in response to draggingEntered we should return no operation. This CL will fix that issue as well as making RenderWidgetHostInputEventRouter::GetRenderWidgetHostAtPoint() handle nullptr |root_view| by returning nullptr. BUG=670645 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2547213002 Cr-Commit-Position: refs/heads/master@{#436146} (cherry picked from commit 5190330169f1e6c1d8418e6bcc0499fdc99ec287)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M content/browser/renderer_host/render_widget_host_input_event_router.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_drag_dest_mac.mm View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
EhsanK
ptal.
4 years ago (2016-12-07 05:33:19 UTC) #3
Avi (use Gerrit)
lgtm
4 years ago (2016-12-07 05:34:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556653003/1
4 years ago (2016-12-07 05:37:14 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-07 05:42:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698