Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2556613003: [OfflinePages] Restarts immediate processing if stopped due to no net (Closed)

Created:
4 years ago by Pete Williamson
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[OfflinePages] Restarts immediate processing if stopped due to no net Adds a ConnectionNotifier helper class to be able to learn when we get connected and uses it in the Coordinator to try immediate start when we get connected after stopping because we had no connection. This is a memory-only network observer so only in effect if chrome stays resident in memory. Otherwise, we still have the GcmNetworkManager scheduler as a fallback. BUG=670119 Review-Url: https://codereview.chromium.org/2546433004 Cr-Commit-Position: refs/heads/master@{#436040} (cherry picked from commit 7103c6cef4c8ed86a090e605e9817d1852452dc2) Committed: https://chromium.googlesource.com/chromium/src/+/3649e1f0d1448d159c37fb3209a6814dc79569a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -1 line) Patch
M components/offline_pages/background/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A components/offline_pages/background/connection_notifier.h View 1 chunk +34 lines, -0 lines 0 comments Download
A components/offline_pages/background/connection_notifier.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M components/offline_pages/background/request_coordinator.h View 3 chunks +12 lines, -0 lines 0 comments Download
M components/offline_pages/background/request_coordinator.cc View 3 chunks +27 lines, -1 line 0 comments Download
M components/offline_pages/background/request_coordinator_unittest.cc View 3 chunks +46 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Pete Williamson
4 years ago (2016-12-06 18:54:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3649e1f0d1448d159c37fb3209a6814dc79569a3.

Powered by Google App Engine
This is Rietveld 408576698