Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 2556603003: spdy: DCHECK parameters should depend on DCHECK_IS_ON() macro. (Closed)

Created:
4 years ago by Alexander Alekseev
Modified:
4 years ago
Reviewers:
brettw
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

spdy: DCHECK parameters should depend on DCHECK_IS_ON() macro. This CL makes the code that is used only in DCHECK to depend on DCHECK_IS_ON() macro. BUG=666660 Committed: https://crrev.com/8302c9619f5f769c1e0b1b1f6c6afd812b0ec63f Cr-Commit-Position: refs/heads/master@{#436744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/spdy/hpack/hpack_huffman_decoder.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Alexander Alekseev
This CL makes the debug code (that is only used in DLOG_IF) depend on the ...
4 years ago (2016-12-06 05:59:58 UTC) #2
brettw
lgtm
4 years ago (2016-12-06 18:50:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556603003/1
4 years ago (2016-12-06 21:03:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 21:44:09 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-06 21:47:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8302c9619f5f769c1e0b1b1f6c6afd812b0ec63f
Cr-Commit-Position: refs/heads/master@{#436744}

Powered by Google App Engine
This is Rietveld 408576698