Change gpu/ipc:command_buffer_sources to static_library

Change gpu/ipc:command_buffer_sources to static_library

A 900 KB size regression popped up at R431519. This CL
fixes it by changing a source_set to a static_library. The effect is to
reduce the size of chrome.dll significantly, fixing the regression:

chrome.dll
     .text: -711776 bytes change
    .rdata: -160752 bytes change
     .data: -10848 bytes change
    .reloc: -33736 bytes change
Total change: -917112 bytes

A custom version of dia2dump.exe was used to find global variables that
appeared in chrome.dll when the regression happened. One of the globals
was cmaa_frag_s2_. This was declared in gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc
so a verbose link of chrome.dll was done and a script (linker_verbose_tracking.py)
was used to find out what was causing this .obj file to be pulled in.
It pointed to in_process_command_buffer.obj, and that led to the fix.

The fix was tested on a release build, but not an official build, so it
is possible that the savings will not apply to official builds. This
will be monitored.

BUG=664481
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/255638d8476e0b6f7a5f8d60a707e10bfa5142d8
Cr-Commit-Position: refs/heads/master@{#436731}

[brucedawson, 2016-12-06 00:37:42]

Description was changed from

==========
Change gpu/ipc:command_buffer_sources to static_library

A 900 KB size regression popped up at R431519. This CL
fixes it by changing a source_set to a static_library. The effect is to
reduce the size of chrome.dll significantly, fixing the regression:

chrome.dll
     .text: -711776 bytes change
    .rdata: -160752 bytes change
     .data: -10848 bytes change
    .reloc: -33736 bytes change
Total change: -917112 bytes

A custom version of dia2dump.exe was used to find global variables that
appeared in chrome.dll when the regression happened. One of the globals
was cmaa_frag_s2_. This was declared in
gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc
so a verbose link of chrome.dll was done and a script
(linker_verbose_tracking.py)
was used to find out what was causing this .obj file to be pulled in.
It pointed to in_process_command_buffer.obj, and that led to the fix.

The fix was tested on a release build, but not an official build, so it
is possible that the savings will not apply to official builds. This
will be monitored.

BUG=664481
==========

to

==========
Change gpu/ipc:command_buffer_sources to static_library

A 900 KB size regression popped up at R431519. This CL
fixes it by changing a source_set to a static_library. The effect is to
reduce the size of chrome.dll significantly, fixing the regression:

chrome.dll
     .text: -711776 bytes change
    .rdata: -160752 bytes change
     .data: -10848 bytes change
    .reloc: -33736 bytes change
Total change: -917112 bytes

A custom version of dia2dump.exe was used to find global variables that
appeared in chrome.dll when the regression happened. One of the globals
was cmaa_frag_s2_. This was declared in
gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc
so a verbose link of chrome.dll was done and a script
(linker_verbose_tracking.py)
was used to find out what was causing this .obj file to be pulled in.
It pointed to in_process_command_buffer.obj, and that led to the fix.

The fix was tested on a release build, but not an official build, so it
is possible that the savings will not apply to official builds. This
will be monitored.

BUG=664481
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[brucedawson, 2016-12-06 00:38:29]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 00:38:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-12-06 00:39:32]

brucedawson@chromium.org changed reviewers:
+ piman@chromium.org

[brucedawson, 2016-12-06 00:39:32]

PTAL - it looks like this saves ~900 KB from chrome.dll.

[commit-bot: I haz the power, 2016-12-06 01:03:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 01:03:50]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[brucedawson, 2016-12-06 01:47:43]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 01:48:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-12-06 02:26:06]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 02:26:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 03:19:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 03:19:18]

Dry run: This issue passed the CQ dry run.

[piman, 2016-12-06 21:10:56]

lgtm

[brucedawson, 2016-12-06 21:11:44]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-12-06 21:12:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 21:23:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481058704470930,
"parent_rev": "0f191aec4aa12a9a367b19498c9f00679bff32f3", "commit_rev":
"632b10ee27d8593418f4c5cdbbff88f501edabe3"}

[commit-bot: I haz the power, 2016-12-06 21:24:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-06 21:25:39]

Description was changed from

==========
Change gpu/ipc:command_buffer_sources to static_library

A 900 KB size regression popped up at R431519. This CL
fixes it by changing a source_set to a static_library. The effect is to
reduce the size of chrome.dll significantly, fixing the regression:

chrome.dll
     .text: -711776 bytes change
    .rdata: -160752 bytes change
     .data: -10848 bytes change
    .reloc: -33736 bytes change
Total change: -917112 bytes

A custom version of dia2dump.exe was used to find global variables that
appeared in chrome.dll when the regression happened. One of the globals
was cmaa_frag_s2_. This was declared in
gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc
so a verbose link of chrome.dll was done and a script
(linker_verbose_tracking.py)
was used to find out what was causing this .obj file to be pulled in.
It pointed to in_process_command_buffer.obj, and that led to the fix.

The fix was tested on a release build, but not an official build, so it
is possible that the savings will not apply to official builds. This
will be monitored.

BUG=664481
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Change gpu/ipc:command_buffer_sources to static_library

A 900 KB size regression popped up at R431519. This CL
fixes it by changing a source_set to a static_library. The effect is to
reduce the size of chrome.dll significantly, fixing the regression:

chrome.dll
     .text: -711776 bytes change
    .rdata: -160752 bytes change
     .data: -10848 bytes change
    .reloc: -33736 bytes change
Total change: -917112 bytes

A custom version of dia2dump.exe was used to find global variables that
appeared in chrome.dll when the regression happened. One of the globals
was cmaa_frag_s2_. This was declared in
gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc
so a verbose link of chrome.dll was done and a script
(linker_verbose_tracking.py)
was used to find out what was causing this .obj file to be pulled in.
It pointed to in_process_command_buffer.obj, and that led to the fix.

The fix was tested on a release build, but not an official build, so it
is possible that the savings will not apply to official builds. This
will be monitored.

BUG=664481
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/255638d8476e0b6f7a5f8d60a707e10bfa5142d8
Cr-Commit-Position: refs/heads/master@{#436731}
==========

[commit-bot: I haz the power, 2016-12-06 21:25:40]

Patchset 3 (id:??) landed as
https://crrev.com/255638d8476e0b6f7a5f8d60a707e10bfa5142d8
Cr-Commit-Position: refs/heads/master@{#436731}