Factor out throwing of argument error.

runtime/lib/string.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 #include "vm/symbols.h"
 #include "vm/unicode.h"
 
 namespace dart {
 
 DEFINE_NATIVE_ENTRY(StringBase_createFromCodePoints, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(Instance, list, arguments->NativeArgAt(0));
   if (!list.IsGrowableObjectArray() && !list.IsArray()) {
-    const Array& args = Array::Handle(Array::New(1));
-    args.SetAt(0, list);
-    Exceptions::ThrowByType(Exceptions::kArgument, args);
+    Exceptions::ThrowArgumentError(list);
   }
 
   Array& a = Array::Handle();
   intptr_t array_len;
   if (list.IsGrowableObjectArray()) {
     const GrowableObjectArray& growableArray = GrowableObjectArray::Cast(list);
     a ^= growableArray.data();
     array_len = growableArray.Length();
   } else {
     a ^= Array::Cast(list).raw();
     array_len = a.Length();
   }
 
   Zone* zone = isolate->current_zone();
 
   // Unbox the array and determine the maximum element width.
   bool is_one_byte_string = true;
   intptr_t utf16_len = array_len;
   int32_t* utf32_array = zone->Alloc<int32_t>(array_len);
-  Object& index_object = Object::Handle(isolate);
+  Instance& index_object = Instance::Handle(isolate);
   for (intptr_t i = 0; i < array_len; i++) {
-    index_object = a.At(i);
+    index_object ^= a.At(i);
     if (!index_object.IsSmi()) {
-      const Array& args = Array::Handle(Array::New(1));
-      args.SetAt(0, index_object);
-      Exceptions::ThrowByType(Exceptions::kArgument, args);
+      Exceptions::ThrowArgumentError(index_object);
     }
     intptr_t value = Smi::Cast(index_object).Value();
     if (Utf::IsOutOfRange(value)) {
       Exceptions::ThrowByType(Exceptions::kArgument, Object::empty_array());
     } else {
       if (!Utf::IsLatin1(value)) {
         is_one_byte_string = false;
         if (Utf::IsSupplementary(value)) {
           utf16_len += 1;
         }
@@ skipping 157 matching lines @@
 }
 
 
 DEFINE_NATIVE_ENTRY(Strings_concatAll, 3) {
   GET_NON_NULL_NATIVE_ARGUMENT(Instance, argument, arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Smi, start, arguments->NativeArgAt(1));
   GET_NON_NULL_NATIVE_ARGUMENT(Smi, end, arguments->NativeArgAt(2));
   const intptr_t start_ix = start.Value();
   const intptr_t end_ix = end.Value();
   if (start_ix < 0) {
-    const Array& args = Array::Handle(Array::New(1));
-    args.SetAt(0, start);
-    Exceptions::ThrowByType(Exceptions::kArgument, args);
+    Exceptions::ThrowArgumentError(start);
   }
   Array& strings = Array::Handle();
   intptr_t length = -1;
   if (argument.IsArray()) {
     strings ^= argument.raw();
     length = strings.Length();
   } else if (argument.IsGrowableObjectArray()) {
     const GrowableObjectArray& g_array = GrowableObjectArray::Cast(argument);
     strings = g_array.data();
     length =  g_array.Length();
   } else {
-    const Array& args = Array::Handle(Array::New(1));
-    args.SetAt(0, argument);
-    Exceptions::ThrowByType(Exceptions::kArgument, args);
+    Exceptions::ThrowArgumentError(argument);
   }
   if (end_ix > length) {
-    const Array& args = Array::Handle(Array::New(1));
-    args.SetAt(0, end);
-    Exceptions::ThrowByType(Exceptions::kArgument, args);
+    Exceptions::ThrowArgumentError(end);
   }
 #if defined(DEBUG)
   // Check that the array contains strings.
   Instance& elem = Instance::Handle();
   for (intptr_t i = start_ix; i < end_ix; i++) {
     elem ^= strings.At(i);
     ASSERT(elem.IsString());
   }
 #endif
   return String::ConcatAllRange(strings, start_ix, end_ix, Heap::kNew);
@@ skipping 15 matching lines @@
       ? String::Handle(OneByteString::New(length_value, Heap::kNew))
       : String::Handle(TwoByteString::New(length_value, Heap::kNew));
   NoGCScope no_gc;
 
   uint16_t* data_position = reinterpret_cast<uint16_t*>(codeUnits.DataAddr(0));
   String::Copy(result, 0, data_position, length_value);
   return result.raw();
 }
 
 }  // namespace dart