Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2556583003: Remove MediaDevices.onondevicechange from WebView stable interfaces (Closed)

Created:
4 years ago by aluo
Modified:
4 years ago
CC:
chromium-reviews, android-webview-reviews_chromium.org, the real yoland, mikecase (-- gone --)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MediaDevices.onondevicechange from WebView stable interfaces BUG=671461 Committed: https://crrev.com/8c76896ad46b39cb0773f2e197302ef98f271032 Cr-Commit-Position: refs/heads/master@{#436607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
aluo
Need to unblock bot: https://build.chromium.org/p/chromium.android/builders/Android%20Webview%20L%20(dbg)
4 years ago (2016-12-06 02:24:51 UTC) #2
timvolodine
thanks for fixing this, lgtm. it would be nice to know if this is indeed ...
4 years ago (2016-12-06 14:14:20 UTC) #9
Guido Urdaneta
Correct. This should not be exposed in WebView.
4 years ago (2016-12-06 14:32:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556583003/1
4 years ago (2016-12-06 15:59:53 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 16:06:30 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-06 16:09:46 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c76896ad46b39cb0773f2e197302ef98f271032
Cr-Commit-Position: refs/heads/master@{#436607}

Powered by Google App Engine
This is Rietveld 408576698