Fix SizeLabelToMinWidth() function such that no unnecessary space

chrome/browser/ui/views/download/download_item_view.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // A view that implements one download on the Download shelf.
 // Each DownloadItemView contains an application icon, a text label
 // indicating the download's file name, a text label indicating the
 // download's status (such as the number of bytes downloaded so far)
 // and a button for canceling an in progress download, or opening
 // the completed download.
@@ skipping 118 matching lines @@
   // gfx::AnimationDelegate implementation.
   void AnimationProgressed(const gfx::Animation* animation) override;
 
  protected:
   // Overridden from views::View:
   void OnPaint(gfx::Canvas* canvas) override;
   void OnFocus() override;
   void OnBlur() override;
 
  private:
+  friend class DownloadItemViewTest;
+
   enum State { NORMAL = 0, HOT, PUSHED };
   class DropDownButton;
 
   enum Mode {
     NORMAL_MODE = 0,  // Showing download item.
     DANGEROUS_MODE,   // Displaying the dangerous download warning.
     MALICIOUS_MODE    // Displaying the malicious download warning.
   };
 
   void OpenDownload();
@@ skipping 58 matching lines @@
 
   // Sets |size| with the size of the Save and Discard buttons (they have the
   // same size).
   gfx::Size GetButtonSize() const;
 
   // Sizes the dangerous download label to a minimum width available using 2
   // lines.  The size is computed only the first time this method is invoked
   // and simply returned on subsequent calls.
   void SizeLabelToMinWidth();
 
+  // Called by SizeLabelToMinWidth() to compute the optimal size of dangerous

[Peter Kasting, 2016/12/08 05:10:23]

Nit: of -> of the, or "of |dangerous_download_label_|"

[Jialiu Lin, 2016/12/08 07:47:40]

Done.

+  // download label and set the text accordingly.
+  gfx::Size GetLabelSize();

[Peter Kasting, 2016/12/08 05:10:23]

Nit: Seems like this should be named SetLabelTextAndGetSize() (or similar), so
it's clear at a glance why it doesn't make sense for it to be const.

[Jialiu Lin, 2016/12/08 07:47:40]

Done.

+
   // Reenables the item after it has been disabled when a user clicked it to
   // open the downloaded file.
   void Reenable();
 
   // Releases drop down button after showing a context menu.
   void ReleaseDropdown();
 
   // Update the accessible name to reflect the current state of the control,
   // so that screenreaders can access the filename, status text, and
   // dangerous download warning message (if any).
@@ skipping 102 matching lines @@
   std::unique_ptr<extensions::ExperienceSamplingEvent> sampling_event_;
 
   // Method factory used to delay reenabling of the item when opening the
   // downloaded file.
   base::WeakPtrFactory<DownloadItemView> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadItemView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_DOWNLOAD_DOWNLOAD_ITEM_VIEW_H_