views: add harmony control label alignment

views: add harmony control label alignment

Harmony specifies leading alignment for these; the old UI style
used trailing alignment mostly, but was inconsistent. This change:

1) Adds HarmonyLayoutDelegate::GetControlLabelGridAlignment();
2) Changes CookieInfoView (used in the collected cookies dialog) to
   use GetControlLabelGridAlignment;
3) Changes the bookmark bubble from leading to trailing alignment

BUG=671828
Committed: https://crrev.com/4aff4df5f338661a2b9c5449ebfe0c33d4311d75
Cr-Commit-Position: refs/heads/master@{#437303}

[Elly Fong-Jones, 2016-12-07 14:27:23]

Description was changed from

==========
views: add harmony control label alignment

Harmony specifies leading alignment for these; the old UI style
used trailing alignment mostly, but was inconsistent. This change:

1) Adds HarmonyLayoutDelegate::GetControlLabelGridAlignment();
2) Changes CookieInfoView (used in the collected cookies dialog) to
   use GetControlLabelGridAlignment;
3) Changes the bookmark bubble from leading to trailing alignment

BUG=671828
==========

to

==========
views: add harmony control label alignment

Harmony specifies leading alignment for these; the old UI style
used trailing alignment mostly, but was inconsistent. This change:

1) Adds HarmonyLayoutDelegate::GetControlLabelGridAlignment();
2) Changes CookieInfoView (used in the collected cookies dialog) to
   use GetControlLabelGridAlignment;
3) Changes the bookmark bubble from leading to trailing alignment

BUG=671828
==========

[Elly Fong-Jones, 2016-12-07 14:27:23]

ellyjones@chromium.org changed reviewers:
+ sky@chromium.org

[Elly Fong-Jones, 2016-12-07 14:27:30]

sky: ptal? :)

[sky, 2016-12-07 16:54:08]

https://codereview.chromium.org/2556563005/diff/1/ui/views/layout/layout_cons...
File ui/views/layout/layout_constants.h (right):

https://codereview.chromium.org/2556563005/diff/1/ui/views/layout/layout_cons...
ui/views/layout/layout_constants.h:84: const GridLayout::Alignment
kControlLabelGridAlignment = GridLayout::TRAILING;
It looks like this is only used by bookmark-bubble. Should we remove it?

[Elly Fong-Jones, 2016-12-07 17:04:02]

On 2016/12/07 16:54:08, sky wrote:
>
https://codereview.chromium.org/2556563005/diff/1/ui/views/layout/layout_cons...
> File ui/views/layout/layout_constants.h (right):
> 
>
https://codereview.chromium.org/2556563005/diff/1/ui/views/layout/layout_cons...
> ui/views/layout/layout_constants.h:84: const GridLayout::Alignment
> kControlLabelGridAlignment = GridLayout::TRAILING;
> It looks like this is only used by bookmark-bubble. Should we remove it?

I added a use of it to CookieInfoView, but we could also remove it and put the
value directly in ViewsDelegate.

[sky, 2016-12-07 18:06:24]

Both are solely in chrome code, so how about moving there?

On Wed, Dec 7, 2016 at 9:04 AM,  <ellyjones@chromium.org> wrote:
> On 2016/12/07 16:54:08, sky wrote:
>>
>
https://codereview.chromium.org/2556563005/diff/1/ui/views/layout/layout_cons...
>> File ui/views/layout/layout_constants.h (right):
>>
>>
>
https://codereview.chromium.org/2556563005/diff/1/ui/views/layout/layout_cons...
>> ui/views/layout/layout_constants.h:84: const GridLayout::Alignment
>> kControlLabelGridAlignment = GridLayout::TRAILING;
>> It looks like this is only used by bookmark-bubble. Should we remove it?
>
> I added a use of it to CookieInfoView, but we could also remove it and put
> the
> value directly in ViewsDelegate.
>
> https://codereview.chromium.org/2556563005/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Elly Fong-Jones, 2016-12-08 13:24:42]

On 2016/12/07 18:06:24, sky wrote:
> Both are solely in chrome code, so how about moving there?

done :)

[sky, 2016-12-08 16:11:54]

LGTM

[Elly Fong-Jones, 2016-12-08 16:31:52]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-12-08 16:32:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 19:18:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481214712579880,
"parent_rev": "c92954453826fd3e9ce71a493fa26f284b8308c1", "commit_rev":
"ec477e593279da15cc1248b1dfad6ddfd9557320"}

[commit-bot: I haz the power, 2016-12-08 19:19:05]

Description was changed from

==========
views: add harmony control label alignment

Harmony specifies leading alignment for these; the old UI style
used trailing alignment mostly, but was inconsistent. This change:

1) Adds HarmonyLayoutDelegate::GetControlLabelGridAlignment();
2) Changes CookieInfoView (used in the collected cookies dialog) to
   use GetControlLabelGridAlignment;
3) Changes the bookmark bubble from leading to trailing alignment

BUG=671828
==========

to

==========
views: add harmony control label alignment

Harmony specifies leading alignment for these; the old UI style
used trailing alignment mostly, but was inconsistent. This change:

1) Adds HarmonyLayoutDelegate::GetControlLabelGridAlignment();
2) Changes CookieInfoView (used in the collected cookies dialog) to
   use GetControlLabelGridAlignment;
3) Changes the bookmark bubble from leading to trailing alignment

BUG=671828
==========

[commit-bot: I haz the power, 2016-12-08 19:19:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-08 19:23:20]

Description was changed from

==========
views: add harmony control label alignment

Harmony specifies leading alignment for these; the old UI style
used trailing alignment mostly, but was inconsistent. This change:

1) Adds HarmonyLayoutDelegate::GetControlLabelGridAlignment();
2) Changes CookieInfoView (used in the collected cookies dialog) to
   use GetControlLabelGridAlignment;
3) Changes the bookmark bubble from leading to trailing alignment

BUG=671828
==========

to

==========
views: add harmony control label alignment

Harmony specifies leading alignment for these; the old UI style
used trailing alignment mostly, but was inconsistent. This change:

1) Adds HarmonyLayoutDelegate::GetControlLabelGridAlignment();
2) Changes CookieInfoView (used in the collected cookies dialog) to
   use GetControlLabelGridAlignment;
3) Changes the bookmark bubble from leading to trailing alignment

BUG=671828

Committed: https://crrev.com/4aff4df5f338661a2b9c5449ebfe0c33d4311d75
Cr-Commit-Position: refs/heads/master@{#437303}
==========

[commit-bot: I haz the power, 2016-12-08 19:23:22]

Patchset 2 (id:??) landed as
https://crrev.com/4aff4df5f338661a2b9c5449ebfe0c33d4311d75
Cr-Commit-Position: refs/heads/master@{#437303}