Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2556563002: Make InsertAllocatorDispatch thread safe. (Closed)

Created:
4 years ago by Sigurður Ásgeirsson
Modified:
4 years ago
CC:
chromium-reviews, wfh+watch_chromium.org, Dai Mikurube (NOT FULLTIME), vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make InsertAllocatorDispatch thread safe. BUG=671193 Committed: https://crrev.com/a2fe22fd6fbc77d3b4ec04a098e6c04d1b064c7e Cr-Commit-Position: refs/heads/master@{#436618}

Patch Set 1 #

Patch Set 2 : Remove the now-redundant single-thread check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -30 lines) Patch
M base/allocator/allocator_shim.h View 1 chunk +3 lines, -3 lines 0 comments Download
M base/allocator/allocator_shim.cc View 1 2 chunks +25 lines, -27 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Sigurður Ásgeirsson
Both of the current shim users are activated on arbitrary threads ATM, and I can't ...
4 years ago (2016-12-05 21:57:00 UTC) #2
Primiano Tucci (use gerrit)
Allright then. LGTM
4 years ago (2016-12-06 16:35:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556563002/20001
4 years ago (2016-12-06 16:35:40 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 16:40:33 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-06 16:42:09 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a2fe22fd6fbc77d3b4ec04a098e6c04d1b064c7e
Cr-Commit-Position: refs/heads/master@{#436618}

Powered by Google App Engine
This is Rietveld 408576698