Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: components/ntp_snippets/remote/remote_suggestions_status_service.h

Issue 2556543003: Add another unittest for configuring sign-in dependency. (Closed)
Patch Set: Marc's comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/remote_suggestions_status_service.h
diff --git a/components/ntp_snippets/remote/remote_suggestions_status_service.h b/components/ntp_snippets/remote/remote_suggestions_status_service.h
index 5e21cd4e73f7e8f17ffc34feed37059cff4d9c2a..e0542bb45e2536e8a6868795c77189b189bbe876 100644
--- a/components/ntp_snippets/remote/remote_suggestions_status_service.h
+++ b/components/ntp_snippets/remote/remote_suggestions_status_service.h
@@ -52,6 +52,11 @@ class RemoteSuggestionsStatusService {
void OnSignInStateChanged();
private:
+ // TODO(jkrcal): Rewrite the tests using the public API - observing status
+ // changes instead of calling private GetStatusFromDeps() directly.
+ FRIEND_TEST_ALL_PREFIXES(RemoteSuggestionsStatusServiceTest,
+ SigninNeededIfSpecifiedByParam);
+ FRIEND_TEST_ALL_PREFIXES(RemoteSuggestionsStatusServiceTest, NoSigninNeeded);
FRIEND_TEST_ALL_PREFIXES(RemoteSuggestionsStatusServiceTest, DisabledViaPref);
// Callback for the PrefChangeRegistrar.

Powered by Google App Engine
This is Rietveld 408576698