Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2556503003: Re-enable threads on ClangToTLinuxLLD. (Closed)

Created:
4 years ago by ruiu
Modified:
4 years ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable threads on ClangToTLinuxLLD. I added -no-threads flag to LLD in 7b18ff885c40874f8e4a417ad03376161b19de0a, but it turned out that the slowness of the bot is generally slow, and it is unlikely that LLD's change is the cause of the problem. This patch restore the original setting. BUG=670397 Committed: https://crrev.com/ffa1f105690aea99deecbdfff6eb40128604b73a Cr-Commit-Position: refs/heads/master@{#436517}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ruiu
4 years ago (2016-12-06 02:26:34 UTC) #4
Nico
On 2016/12/06 02:26:34, ruiu wrote: Lgtm. You could've also clicked the "revert" button on the ...
4 years ago (2016-12-06 03:05:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556503003/1
4 years ago (2016-12-06 03:24:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 03:56:29 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-06 03:59:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffa1f105690aea99deecbdfff6eb40128604b73a
Cr-Commit-Position: refs/heads/master@{#436517}

Powered by Google App Engine
This is Rietveld 408576698