Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2556503002: [Devtools] Update Acorn (Closed)

Created:
4 years ago by allada
Modified:
4 years ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Update Acorn This patch simply updates acorn to 4.0.3. NOPRESUBMIT=true R=lushnikov BUG=667894 Committed: https://crrev.com/1f78e2d88c8ad8d25e52176c4b76481b383625cb Cr-Commit-Position: refs/heads/master@{#436474}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2775 lines, -2678 lines) Patch
M third_party/WebKit/Source/devtools/front_end/formatter_worker/acorn/acorn.js View 3 chunks +2775 lines, -2678 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (11 generated)
allada
PTL
4 years ago (2016-12-05 20:21:03 UTC) #1
lushnikov
lgtm
4 years ago (2016-12-05 20:28:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556503002/1
4 years ago (2016-12-06 00:44:58 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/318974)
4 years ago (2016-12-06 00:52:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556503002/1
4 years ago (2016-12-06 00:53:38 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 00:54:52 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-06 00:57:24 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f78e2d88c8ad8d25e52176c4b76481b383625cb
Cr-Commit-Position: refs/heads/master@{#436474}

Powered by Google App Engine
This is Rietveld 408576698