Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 25565002: Make all v1 app windows use the same maximized window frame (Closed)

Created:
7 years, 2 months ago by pkotwicz
Modified:
7 years, 1 month ago
Reviewers:
stevenjb
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Make all v1 app windows use the same maximized window frame. BUG=297174 TEST=None

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -29 lines) Patch
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_browsertest.cc View 1 2 chunks +2 lines, -25 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_aura.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pkotwicz
Steven, can you please take a look? To the extent of my knowledge the special ...
7 years, 2 months ago (2013-10-01 17:39:48 UTC) #1
stevenjb
On 2013/10/01 17:39:48, pkotwicz wrote: > Steven, can you please take a look? To the ...
7 years, 2 months ago (2013-10-01 18:59:05 UTC) #2
pkotwicz
7 years, 1 month ago (2013-10-27 23:40:12 UTC) #3
I am closing this CL because we have changed the design of the window frame for
v1 apps. I will post a doc outlining the design of the window frame for v1 and
v2 apps on Monday

Powered by Google App Engine
This is Rietveld 408576698