Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2556443003: Add chrome_apps_resources.pak to resources.pak. (Closed)

Created:
4 years ago by fukino
Modified:
4 years ago
Reviewers:
satorux1
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add chrome_apps_resources.pak to resources.pak. webstore_widget extension, which is a part of chrome_app_resources.pak, was not included in resources.pak. It resulted in "Failed to parse extension manifest." error. chrome_app_resources.pak was added in https://codereview.chromium.org/1103943003/diff/140001/chrome/chrome_repack_resources.gypi, but it was included in resources.pak only in GYP build. Doing the same for GN build fixes the issue. BUG=671521 TEST=boot Chrome OS and confirm that "Failed to parse extension manifest.' is not observed. Committed: https://crrev.com/27d65fa315b9eaa62db39ab9f2244e27d54377a9 Cr-Commit-Position: refs/heads/master@{#436862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/chrome_paks.gni View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
fukino
4 years ago (2016-12-06 09:36:51 UTC) #2
satorux1
lgtm. nice finding! btw, i wonder why it didn't cause a build error...
4 years ago (2016-12-07 02:30:51 UTC) #3
fukino
On 2016/12/07 02:30:51, satorux1 wrote: > lgtm. nice finding! btw, i wonder why it didn't ...
4 years ago (2016-12-07 03:30:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556443003/1
4 years ago (2016-12-07 03:31:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 04:45:08 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-07 04:47:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27d65fa315b9eaa62db39ab9f2244e27d54377a9
Cr-Commit-Position: refs/heads/master@{#436862}

Powered by Google App Engine
This is Rietveld 408576698