Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2556433004: Disallow deprecated typedef syntax for mixin apps in the VM (fixes #14410). (Closed)

Created:
4 years ago by regis
Modified:
4 years ago
Reviewers:
floitsch, scheglov
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disallow deprecated typedef syntax for mixin apps in the VM (fixes #14410). Update status files (will reassign issue #14410 to dart2js, since it still accepts the syntax). R=floitsch@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/6da1083953e8956faed0bb8619bc8728055b1725

Patch Set 1 #

Patch Set 2 : dedup test 13 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -38 lines) Patch
M runtime/vm/parser.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 3 chunks +0 lines, -26 lines 0 comments Download
M tests/language/language_analyzer2.status View 2 chunks +0 lines, -4 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_kernel.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/mixin_illegal_syntax_test.dart View 1 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
regis
4 years ago (2016-12-07 00:39:49 UTC) #2
scheglov
lgtm
4 years ago (2016-12-07 02:45:29 UTC) #3
floitsch
LGTM.
4 years ago (2016-12-07 13:14:01 UTC) #4
regis
Thank you, both!
4 years ago (2016-12-07 15:33:49 UTC) #5
regis
4 years ago (2016-12-07 15:34:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6da1083953e8956faed0bb8619bc8728055b1725 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698