components/subresource_filter/content/renderer/subresource_filter_agent.h - Issue 2556433003: Support optional performance measuring in SubresourceFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/renderer/subresource_filter_agent.h

Issue 2556433003: Support optional performance measuring in SubresourceFilter. (Closed)

Patch Set: Link TODO to a bug. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/renderer/document_subresource_filter_unittest.cc ('k') | components/subresource_filter/content/renderer/subresource_filter_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/renderer/subresource_filter_agent.h

diff --git a/components/subresource_filter/content/renderer/subresource_filter_agent.h b/components/subresource_filter/content/renderer/subresource_filter_agent.h

index 864e197d5ad40fe37e913d1c5d205cda33707b76..43beacd3799feeaade7970203e34fdea2de7e0af 100644

--- a/components/subresource_filter/content/renderer/subresource_filter_agent.h

+++ b/components/subresource_filter/content/renderer/subresource_filter_agent.h

@@ -58,7 +58,8 @@ class SubresourceFilterAgent

private:

void OnActivateForProvisionalLoad(ActivationState activation_state,

- const GURL& url);

+ const GURL& url,

+ bool measure_performance);

void RecordHistogramsOnLoadCommitted();

void RecordHistogramsOnLoadFinished();

@@ -75,6 +76,7 @@ class SubresourceFilterAgent

ActivationState activation_state_for_provisional_load_;

GURL url_for_provisional_load_;

+ bool measure_performance_ = false;

base::WeakPtr<DocumentSubresourceFilter> filter_for_last_committed_load_;

DISALLOW_COPY_AND_ASSIGN(SubresourceFilterAgent);