components/subresource_filter/content/renderer/document_subresource_filter.h - Issue 2556433003: Support optional performance measuring in SubresourceFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/renderer/document_subresource_filter.h

Issue 2556433003: Support optional performance measuring in SubresourceFilter. (Closed)

Patch Set: Link TODO to a bug. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/common/subresource_filter_messages.h ('k') | components/subresource_filter/content/renderer/document_subresource_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/renderer/document_subresource_filter.h

diff --git a/components/subresource_filter/content/renderer/document_subresource_filter.h b/components/subresource_filter/content/renderer/document_subresource_filter.h

index 385813124115c53232a66620469e62a14c8b679b..7518b12821c0b078a2aeaaf0e583aa4470513e10 100644

--- a/components/subresource_filter/content/renderer/document_subresource_filter.h

+++ b/components/subresource_filter/content/renderer/document_subresource_filter.h

@@ -58,6 +58,7 @@ class DocumentSubresourceFilter

// first disallowed subresource load.

DocumentSubresourceFilter(

ActivationState activation_state,

+ bool measure_performance,

const scoped_refptr<const MemoryMappedRuleset>& ruleset,

const std::vector<GURL>& ancestor_document_urls,

const base::Closure& first_disallowed_load_callback);

@@ -70,7 +71,9 @@ class DocumentSubresourceFilter

blink::WebURLRequest::RequestContext) override;

private:

- ActivationState activation_state_;

+ const ActivationState activation_state_;

+ const bool measure_performance_;

scoped_refptr<const MemoryMappedRuleset> ruleset_;

IndexedRulesetMatcher ruleset_matcher_;