Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

Issue 2556433003: Support optional performance measuring in SubresourceFilter. (Closed)
Patch Set: Link TODO to a bug. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/subresource_filter/content/browser/content_subresource_filter_driver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
index 5456b783d3407ad9448267f4f45d41849377cb53..1dfefce466c88a0cdf8ab26b5b18872cc9e8bed1 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
@@ -112,8 +112,8 @@ class MockSubresourceFilterDriver
~MockSubresourceFilterDriver() override = default;
- MOCK_METHOD2(ActivateForProvisionalLoad,
- void(subresource_filter::ActivationState, const GURL&));
+ MOCK_METHOD3(ActivateForProvisionalLoad,
+ void(subresource_filter::ActivationState, const GURL&, bool));
private:
DISALLOW_COPY_AND_ASSIGN(MockSubresourceFilterDriver);
@@ -958,7 +958,8 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest,
EXPECT_CALL(observer_, OnSafeBrowsingHit(IsUnsafeResourceFor(bad_url)))
.Times(1);
- EXPECT_CALL(*driver(), ActivateForProvisionalLoad(::testing::_, ::testing::_))
+ EXPECT_CALL(*driver(), ActivateForProvisionalLoad(::testing::_, ::testing::_,
+ ::testing::_))
.Times(0);
ui_test_utils::NavigateToURL(browser(), bad_url);
Mock::VerifyAndClearExpectations(&observer_);
@@ -967,7 +968,8 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest,
content::WaitForInterstitialAttach(main_contents);
EXPECT_TRUE(ShowingInterstitialPage());
testing::Mock::VerifyAndClearExpectations(driver());
- EXPECT_CALL(*driver(), ActivateForProvisionalLoad(::testing::_, ::testing::_))
+ EXPECT_CALL(*driver(), ActivateForProvisionalLoad(::testing::_, ::testing::_,
+ ::testing::_))
.Times(1);
InterstitialPage* interstitial_page = main_contents->GetInterstitialPage();
ASSERT_TRUE(interstitial_page);
@@ -998,7 +1000,8 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest, SocEngReportingBlacklistEmpty) {
EXPECT_CALL(observer_, OnSafeBrowsingHit(IsUnsafeResourceFor(bad_url)))
.Times(1);
- EXPECT_CALL(*driver(), ActivateForProvisionalLoad(::testing::_, ::testing::_))
+ EXPECT_CALL(*driver(), ActivateForProvisionalLoad(::testing::_, ::testing::_,
+ ::testing::_))
.Times(0);
ui_test_utils::NavigateToURL(browser(), bad_url);
testing::Mock::VerifyAndClearExpectations(driver());
@@ -1007,7 +1010,8 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest, SocEngReportingBlacklistEmpty) {
content::WaitForInterstitialAttach(main_contents);
EXPECT_TRUE(ShowingInterstitialPage());
testing::Mock::VerifyAndClearExpectations(driver());
- EXPECT_CALL(*driver(), ActivateForProvisionalLoad(::testing::_, ::testing::_))
+ EXPECT_CALL(*driver(), ActivateForProvisionalLoad(::testing::_, ::testing::_,
+ ::testing::_))
.Times(0);
InterstitialPage* interstitial_page = main_contents->GetInterstitialPage();
ASSERT_TRUE(interstitial_page);
« no previous file with comments | « no previous file | components/subresource_filter/content/browser/content_subresource_filter_driver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698